From 42650a2a3f945c33d3eccdd4be9a09e6d8264a27 Mon Sep 17 00:00:00 2001 From: Carlos Garcia Campos Date: Mon, 25 Mar 2013 12:09:52 +0100 Subject: [PATCH] gtkprintbackendcups: Fix a crash in gtk_print_backend_cups_finalize() If GtkPrintBackendCups is finalized and cups_get_printer_list hasn't been called, g_object_unref is called for the GDBusConnection pointer that is NULL. Use g_clear_object() instead. https://bugzilla.gnome.org/show_bug.cgi?id=696546 --- modules/printbackends/cups/gtkprintbackendcups.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/printbackends/cups/gtkprintbackendcups.c b/modules/printbackends/cups/gtkprintbackendcups.c index 64b92bcddd..45aa007bce 100644 --- a/modules/printbackends/cups/gtkprintbackendcups.c +++ b/modules/printbackends/cups/gtkprintbackendcups.c @@ -852,7 +852,7 @@ gtk_print_backend_cups_finalize (GObject *object) g_clear_object (&backend_cups->avahi_cancellable); g_clear_pointer (&backend_cups->avahi_default_printer, g_free); - g_object_unref (backend_cups->dbus_connection); + g_clear_object (&backend_cups->dbus_connection); #endif backend_parent_class->finalize (object);