From 44afc537b36fa81a75ec3f16823ab67a60e2500e Mon Sep 17 00:00:00 2001 From: Owen Taylor Date: Mon, 31 Jul 2000 20:48:38 +0000 Subject: [PATCH] Replace broken, (broken, Elliot, every single window blank on X) custom Mon Jul 31 16:45:48 2000 Owen Taylor * gdk/gdkwindow.c (gdk_window_process_updates_internal): Replace broken, (broken, Elliot, every single window blank on X) custom code with call to gdk_window_is_viewable() which a) prevents code duplicate and b) works. --- ChangeLog | 7 +++++++ ChangeLog.pre-2-0 | 7 +++++++ ChangeLog.pre-2-10 | 7 +++++++ ChangeLog.pre-2-2 | 7 +++++++ ChangeLog.pre-2-4 | 7 +++++++ ChangeLog.pre-2-6 | 7 +++++++ ChangeLog.pre-2-8 | 7 +++++++ configure.in | 2 +- gdk/gdkwindow.c | 9 +++------ 9 files changed, 53 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 20d28c7411..e58e000f0a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Mon Jul 31 16:45:48 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Replace broken, + (broken, Elliot, every single window blank on X) custom code with call + to gdk_window_is_viewable() which a) prevents code duplicate and + b) works. + 2000-07-31 Elliot Lee * gtk/gtkcolorsel.c: We really do need to include gdkfb.h in order to get the GDK_PARENT_ROOT() macro to work. diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0 index 20d28c7411..e58e000f0a 100644 --- a/ChangeLog.pre-2-0 +++ b/ChangeLog.pre-2-0 @@ -1,3 +1,10 @@ +Mon Jul 31 16:45:48 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Replace broken, + (broken, Elliot, every single window blank on X) custom code with call + to gdk_window_is_viewable() which a) prevents code duplicate and + b) works. + 2000-07-31 Elliot Lee * gtk/gtkcolorsel.c: We really do need to include gdkfb.h in order to get the GDK_PARENT_ROOT() macro to work. diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 20d28c7411..e58e000f0a 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,10 @@ +Mon Jul 31 16:45:48 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Replace broken, + (broken, Elliot, every single window blank on X) custom code with call + to gdk_window_is_viewable() which a) prevents code duplicate and + b) works. + 2000-07-31 Elliot Lee * gtk/gtkcolorsel.c: We really do need to include gdkfb.h in order to get the GDK_PARENT_ROOT() macro to work. diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index 20d28c7411..e58e000f0a 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,10 @@ +Mon Jul 31 16:45:48 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Replace broken, + (broken, Elliot, every single window blank on X) custom code with call + to gdk_window_is_viewable() which a) prevents code duplicate and + b) works. + 2000-07-31 Elliot Lee * gtk/gtkcolorsel.c: We really do need to include gdkfb.h in order to get the GDK_PARENT_ROOT() macro to work. diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index 20d28c7411..e58e000f0a 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,10 @@ +Mon Jul 31 16:45:48 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Replace broken, + (broken, Elliot, every single window blank on X) custom code with call + to gdk_window_is_viewable() which a) prevents code duplicate and + b) works. + 2000-07-31 Elliot Lee * gtk/gtkcolorsel.c: We really do need to include gdkfb.h in order to get the GDK_PARENT_ROOT() macro to work. diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 20d28c7411..e58e000f0a 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,10 @@ +Mon Jul 31 16:45:48 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Replace broken, + (broken, Elliot, every single window blank on X) custom code with call + to gdk_window_is_viewable() which a) prevents code duplicate and + b) works. + 2000-07-31 Elliot Lee * gtk/gtkcolorsel.c: We really do need to include gdkfb.h in order to get the GDK_PARENT_ROOT() macro to work. diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 20d28c7411..e58e000f0a 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,10 @@ +Mon Jul 31 16:45:48 2000 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_process_updates_internal): Replace broken, + (broken, Elliot, every single window blank on X) custom code with call + to gdk_window_is_viewable() which a) prevents code duplicate and + b) works. + 2000-07-31 Elliot Lee * gtk/gtkcolorsel.c: We really do need to include gdkfb.h in order to get the GDK_PARENT_ROOT() macro to work. diff --git a/configure.in b/configure.in index 590144a316..ae67813d8c 100644 --- a/configure.in +++ b/configure.in @@ -212,7 +212,7 @@ AC_SUBST(STRIP_BEGIN) AC_SUBST(STRIP_END) # i18n stuff -ALL_LINGUAS="ca cs da de el es et eu fi fr ga gl hr hu it ja ko lt nl no pl pt pt_BR ro ru sk sl sp sr sv tr uk wa zh_TW.Big5 zh_CN.GB2312" +ALL_LINGUAS="ca cs da de el es et eu fi fr ga gl he hr hu it ja ko lt nl no pl pt pt_BR ro ru sk sl sp sr sv tr uk wa zh_TW.Big5 zh_CN.GB2312" AM_GTK_GNU_GETTEXT LIBS="$LIBS $INTLLIBS" diff --git a/gdk/gdkwindow.c b/gdk/gdkwindow.c index fd3b068ae5..d019b7c206 100644 --- a/gdk/gdkwindow.c +++ b/gdk/gdkwindow.c @@ -1413,14 +1413,11 @@ static guint update_idle = 0; static void gdk_window_process_updates_internal (GdkWindow *window) { - GdkWindowObject *private = (GdkWindowObject *)window, *cur; + GdkWindowObject *private = (GdkWindowObject *)window; gboolean save_region = FALSE; - for(cur = private; cur; cur = cur->parent) - { - if(!cur->mapped) - return; - } + if (!gdk_window_is_viewable (window)) + return; /* If an update got queued during update processing, we can get a * window in the update queue that has an empty update_area.