From 48bb9200d913607cf0556c55c7da968bdb36024a Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 21 Oct 2020 14:40:34 -0400 Subject: [PATCH] a11y: Treat PRESENTATION like NONE This is what ARIA tells us to do. NONE is just another name for PRESENTATION. --- gtk/gtkaccessible.c | 3 ++- gtk/gtkenums.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/gtk/gtkaccessible.c b/gtk/gtkaccessible.c index bef2ced14e..a98bd90ae2 100644 --- a/gtk/gtkaccessible.c +++ b/gtk/gtkaccessible.c @@ -746,7 +746,8 @@ gtk_accessible_should_present (GtkAccessible *self) !gtk_widget_get_visible (GTK_WIDGET (self))) return FALSE; - if (gtk_accessible_get_accessible_role (self) == GTK_ACCESSIBLE_ROLE_NONE) + if (gtk_accessible_get_accessible_role (self) == GTK_ACCESSIBLE_ROLE_NONE || + gtk_accessible_get_accessible_role (self) == GTK_ACCESSIBLE_ROLE_PRESENTATION) return FALSE; return TRUE; diff --git a/gtk/gtkenums.h b/gtk/gtkenums.h index 36e90b71bb..28ed4fb2f1 100644 --- a/gtk/gtkenums.h +++ b/gtk/gtkenums.h @@ -1202,7 +1202,7 @@ typedef enum { * @GTK_ACCESSIBLE_ROLE_NONE: An element that is not represented to accessibility technologies. * @GTK_ACCESSIBLE_ROLE_NOTE: Unused * @GTK_ACCESSIBLE_ROLE_OPTION: Unused - * @GTK_ACCESSIBLE_ROLE_PRESENTATION: Unused + * @GTK_ACCESSIBLE_ROLE_PRESENTATION: An element that is not represented to accessibility technologies. * @GTK_ACCESSIBLE_ROLE_PROGRESS_BAR: An element that displays the progress * status for tasks that take a long time. * @GTK_ACCESSIBLE_ROLE_RADIO: A checkable input in a group of radio roles,