From 62ed8cb11504bb077f93b5e5d97ee561754642f0 Mon Sep 17 00:00:00 2001 From: Federico Mena Quintero Date: Tue, 29 Nov 2005 01:15:13 +0000 Subject: [PATCH] Fixes the critical warnings from bug #317999, thus fixing the bug 2005-11-28 Federico Mena Quintero Fixes the critical warnings from bug #317999, thus fixing the bug completely: * gtk/gtkfilechooserdefault.c (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode, use _gtk_file_chooser_get_current_folder_path() instead of fetching the impl->current_folder directly. The latter may be null if we are in RELOAD_NONE state. --- ChangeLog | 11 +++++++++++ ChangeLog.pre-2-10 | 11 +++++++++++ gtk/gtkfilechooserdefault.c | 2 +- 3 files changed, 23 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 876bb3f965..f25ba7e561 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2005-11-28 Federico Mena Quintero + + Fixes the critical warnings from bug #317999, thus fixing the bug + completely: + + * gtk/gtkfilechooserdefault.c + (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode, + use _gtk_file_chooser_get_current_folder_path() instead of fetching the + impl->current_folder directly. The latter may be null if we are + in RELOAD_NONE state. + 2005-11-28 Federico Mena Quintero Fix bug #321560, based on a patch by Bogdan Nicula (bogdanni@hotmail.com): diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 876bb3f965..f25ba7e561 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,14 @@ +2005-11-28 Federico Mena Quintero + + Fixes the critical warnings from bug #317999, thus fixing the bug + completely: + + * gtk/gtkfilechooserdefault.c + (gtk_file_chooser_default_get_paths): In SELECT_FOLDER mode, + use _gtk_file_chooser_get_current_folder_path() instead of fetching the + impl->current_folder directly. The latter may be null if we are + in RELOAD_NONE state. + 2005-11-28 Federico Mena Quintero Fix bug #321560, based on a patch by Bogdan Nicula (bogdanni@hotmail.com): diff --git a/gtk/gtkfilechooserdefault.c b/gtk/gtkfilechooserdefault.c index ebf4ddc0cd..00a78a9706 100644 --- a/gtk/gtkfilechooserdefault.c +++ b/gtk/gtkfilechooserdefault.c @@ -5701,7 +5701,7 @@ gtk_file_chooser_default_get_paths (GtkFileChooser *chooser) if (impl->action == GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER && info.result == NULL) { - info.result = g_slist_prepend (info.result, gtk_file_path_copy (impl->current_folder)); + info.result = g_slist_prepend (info.result, _gtk_file_chooser_get_current_folder_path (chooser)); } return g_slist_reverse (info.result);