From 655736b05f5f8780ef5cc3caf3217e109e1e2763 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 16 Oct 2024 10:12:48 -0400 Subject: [PATCH] gdk: Bling up debug spew slightly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We use ✓ and ✗ in some other places already, be consistent. --- gdk/gdkglcontext.c | 16 ++++++---------- gdk/gdkvulkancontext.c | 4 ++-- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/gdk/gdkglcontext.c b/gdk/gdkglcontext.c index ddb042c38a..46d9530204 100644 --- a/gdk/gdkglcontext.c +++ b/gdk/gdkglcontext.c @@ -382,8 +382,6 @@ gdk_gl_context_create_egl_context (GdkGLContext *context, if (ctx == EGL_NO_CONTEXT) return 0; - GDK_DISPLAY_DEBUG (display, OPENGL, "Created EGL context[%p]", ctx); - priv->egl_context = ctx; gdk_gl_context_set_version (context, &supported_versions[j]); gdk_gl_context_set_is_legacy (context, legacy); @@ -1752,22 +1750,20 @@ gdk_gl_context_check_extensions (GdkGLContext *context) { int i, max_texture_size; glGetIntegerv (GL_MAX_TEXTURE_SIZE, &max_texture_size); - gdk_debug_message ("%s version: %d.%d (%s)\n" - "* GLSL version: %s\n" - "* Max texture size: %d\n", + gdk_debug_message ("%s version: %d.%d (%s)", gdk_gl_context_get_use_es (context) ? "OpenGL ES" : "OpenGL", gdk_gl_version_get_major (&priv->gl_version), gdk_gl_version_get_minor (&priv->gl_version), - priv->is_legacy ? "legacy" : "core", - glGetString (GL_SHADING_LANGUAGE_VERSION), - max_texture_size); + priv->is_legacy ? "legacy" : "core"); + gdk_debug_message ("GLSL version: %s", glGetString (GL_SHADING_LANGUAGE_VERSION)); + gdk_debug_message ("Max texture size: %d", max_texture_size); gdk_debug_message ("Enabled features (use GDK_GL_DISABLE env var to disable):"); for (i = 0; i < G_N_ELEMENTS (gdk_gl_feature_keys); i++) { gdk_debug_message (" %s: %s", gdk_gl_feature_keys[i].key, - (priv->features & gdk_gl_feature_keys[i].value) ? "YES" : + (priv->features & gdk_gl_feature_keys[i].value) ? "✓" : ((disabled_features & gdk_gl_feature_keys[i].value) ? "disabled via env var" : - (((supported_features & gdk_gl_feature_keys[i].value) == 0) ? "not supported" : + (((supported_features & gdk_gl_feature_keys[i].value) == 0) ? "✗" : "Hum, what? This should not happen."))); } } diff --git a/gdk/gdkvulkancontext.c b/gdk/gdkvulkancontext.c index 57a9cf172c..caea9ced40 100644 --- a/gdk/gdkvulkancontext.c +++ b/gdk/gdkvulkancontext.c @@ -1626,9 +1626,9 @@ gdk_display_create_vulkan_device (GdkDisplay *display, { GDK_DISPLAY_DEBUG (display, VULKAN, " %s: %s", gdk_vulkan_feature_keys[i].key, - (features & gdk_vulkan_feature_keys[i].value) ? "YES" : + (features & gdk_vulkan_feature_keys[i].value) ? "✓" : ((skip_features & gdk_vulkan_feature_keys[i].value) ? "disabled via env var" : - (((device_features & gdk_vulkan_feature_keys[i].value) == 0) ? "not supported" : + (((device_features & gdk_vulkan_feature_keys[i].value) == 0) ? "✗" : "Hum, what? This should not happen."))); }