From 6855e1eec36033f84aa8d2f8cd2ab77ace474064 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 26 Feb 2015 20:55:54 -0500 Subject: [PATCH] app chooser dialog: Prevent uneven button heights The height of the text buttons depends on the font height, whereas the search button has a fixed-size icon in it... Prevent unevent heights by putting them all in a size group. --- gtk/gtkappchooserdialog.c | 5 +++++ gtk/ui/gtkappchooserdialog.ui | 7 +++++++ 2 files changed, 12 insertions(+) diff --git a/gtk/gtkappchooserdialog.c b/gtk/gtkappchooserdialog.c index 204b415607..c58206356a 100644 --- a/gtk/gtkappchooserdialog.c +++ b/gtk/gtkappchooserdialog.c @@ -57,6 +57,7 @@ #include "gtkheaderbar.h" #include "gtkdialogprivate.h" #include "gtksearchbar.h" +#include "gtksizegroup.h" #include #include @@ -80,6 +81,8 @@ struct _GtkAppChooserDialogPrivate { GtkWidget *show_more_button; GtkWidget *software_button; + GtkSizeGroup *buttons; + gboolean show_more_clicked; gboolean dismissed; }; @@ -494,6 +497,7 @@ setup_search (GtkAppChooserDialog *self) header = gtk_dialog_get_header_bar (GTK_DIALOG (self)); gtk_header_bar_pack_end (GTK_HEADER_BAR (header), button); + gtk_size_group_add_widget (self->priv->buttons, button); g_object_bind_property (button, "active", self->priv->search_bar, "search-mode-enabled", @@ -696,6 +700,7 @@ gtk_app_chooser_dialog_class_init (GtkAppChooserDialogClass *klass) gtk_widget_class_bind_template_child_private (widget_class, GtkAppChooserDialog, inner_box); gtk_widget_class_bind_template_child_private (widget_class, GtkAppChooserDialog, search_bar); gtk_widget_class_bind_template_child_private (widget_class, GtkAppChooserDialog, search_entry); + gtk_widget_class_bind_template_child_private (widget_class, GtkAppChooserDialog, buttons); gtk_widget_class_bind_template_callback (widget_class, show_more_button_clicked_cb); gtk_widget_class_bind_template_callback (widget_class, software_button_clicked_cb); } diff --git a/gtk/ui/gtkappchooserdialog.ui b/gtk/ui/gtkappchooserdialog.ui index bc7df6a932..be7dfe4ace 100644 --- a/gtk/ui/gtkappchooserdialog.ui +++ b/gtk/ui/gtkappchooserdialog.ui @@ -108,4 +108,11 @@ True + + vertical + + + + +