From 6c06e1855e7ecdeca3a529adff053e409ebf9502 Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Thu, 25 Jul 2024 22:06:27 +0200 Subject: [PATCH] roaring: Fix a compiler warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a simple fix, I did not investigate if NULL is actually possible here. In function ‘bitset_container_empty’, inlined from ‘bitset_container_const_nonzero_cardinality’ at ../gtk/roaring/roaring.h:1942:13, inlined from ‘container_nonzero_cardinality’ at ../gtk/roaring/roaring.h:4055:20, inlined from ‘roaring_bitmap_lazy_xor’ at ../gtk/roaring/roaring.c:9727:17: ../gtk/roaring/roaring.h:1928:13: error: potential null pointer dereference [-Werror=null-dereference] 1928 | if (bitset->cardinality == BITSET_UNKNOWN_CARDINALITY) { | ~~~~~~^~~~~~~~~~~~~ --- gtk/roaring/roaring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/roaring/roaring.c b/gtk/roaring/roaring.c index 8774a6e293..89e56c736c 100644 --- a/gtk/roaring/roaring.c +++ b/gtk/roaring/roaring.c @@ -9724,7 +9724,7 @@ roaring_bitmap_t *roaring_bitmap_lazy_xor(const roaring_bitmap_t *x1, container_lazy_xor(c1, container_type_1, c2, container_type_2, &container_result_type); - if (container_nonzero_cardinality(c, container_result_type)) { + if (c && container_nonzero_cardinality(c, container_result_type)) { ra_append(&answer->high_low_container, s1, c, container_result_type); } else {