Drop most uses of GtkMisc in tests

Replace them by GtkWidget h/valign. The only remaining uses
are those where a size group is involved; they can't be replaced
until GtkLabel stops looking at GtkMisc alignment for size
allocation.
This commit is contained in:
Matthias Clasen
2014-05-13 07:28:20 -04:00
parent 49188aeeda
commit 7840bad5d7
4 changed files with 19 additions and 38 deletions

View File

@@ -55,7 +55,7 @@ main (int argc, char **argv)
gtk_box_pack_end (GTK_BOX (vbox), scale, FALSE, FALSE, 0); gtk_box_pack_end (GTK_BOX (vbox), scale, FALSE, FALSE, 0);
label = gtk_label_new ("Event processing time (ms):"); label = gtk_label_new ("Event processing time (ms):");
gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); gtk_widget_set_halign (label, GTK_ALIGN_CENTER);
gtk_box_pack_end (GTK_BOX (vbox), label, FALSE, FALSE, 0); gtk_box_pack_end (GTK_BOX (vbox), label, FALSE, FALSE, 0);
g_signal_connect (window, "motion-notify-event", g_signal_connect (window, "motion-notify-event",

View File

@@ -70,18 +70,6 @@ combochange_log (const char *fmt,
g_free (msg); g_free (msg);
} }
static GtkWidget *
align_button_new (const char *text)
{
GtkWidget *button = gtk_button_new ();
GtkWidget *label = gtk_label_new (text);
gtk_container_add (GTK_CONTAINER (button), label);
gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
return button;
}
static GtkWidget * static GtkWidget *
create_combo (const char *name, create_combo (const char *name,
gboolean is_list) gboolean is_list)
@@ -241,7 +229,6 @@ main (int argc, char **argv)
GtkWidget *combo_vbox; GtkWidget *combo_vbox;
GtkWidget *button; GtkWidget *button;
GtkWidget *menu_combo; GtkWidget *menu_combo;
GtkWidget *alignment;
GtkWidget *label; GtkWidget *label;
GtkWidget *list_combo; GtkWidget *list_combo;
@@ -268,25 +255,19 @@ main (int argc, char **argv)
label = gtk_label_new (NULL); label = gtk_label_new (NULL);
gtk_label_set_markup (GTK_LABEL (label), "<b>Menu mode</b>"); gtk_label_set_markup (GTK_LABEL (label), "<b>Menu mode</b>");
gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
gtk_box_pack_start (GTK_BOX (combo_vbox), label, FALSE, FALSE, 0); gtk_box_pack_start (GTK_BOX (combo_vbox), label, FALSE, FALSE, 0);
alignment = g_object_new (GTK_TYPE_ALIGNMENT, "left-padding", 12, NULL);
gtk_box_pack_start (GTK_BOX (combo_vbox), alignment, FALSE, FALSE, 0);
menu_combo = create_combo ("menu-combo", FALSE); menu_combo = create_combo ("menu-combo", FALSE);
gtk_container_add (GTK_CONTAINER (alignment), menu_combo); gtk_widget_set_margin_start (menu_combo, 12);
gtk_box_pack_start (GTK_BOX (combo_vbox), menu_combo, FALSE, FALSE, 0);
label = gtk_label_new (NULL); label = gtk_label_new (NULL);
gtk_label_set_markup (GTK_LABEL (label), "<b>List mode</b>"); gtk_label_set_markup (GTK_LABEL (label), "<b>List mode</b>");
gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
gtk_box_pack_start (GTK_BOX (combo_vbox), label, FALSE, FALSE, 0); gtk_box_pack_start (GTK_BOX (combo_vbox), label, FALSE, FALSE, 0);
alignment = g_object_new (GTK_TYPE_ALIGNMENT, "left-padding", 12, NULL);
gtk_box_pack_start (GTK_BOX (combo_vbox), alignment, FALSE, FALSE, 0);
list_combo = create_combo ("list-combo", TRUE); list_combo = create_combo ("list-combo", TRUE);
gtk_container_add (GTK_CONTAINER (alignment), list_combo); gtk_widget_set_margin_start (list_combo, 12);
gtk_box_pack_start (GTK_BOX (combo_vbox), list_combo, FALSE, FALSE, 0);
scrolled_window = gtk_scrolled_window_new (NULL, NULL); scrolled_window = gtk_scrolled_window_new (NULL, NULL);
gtk_box_pack_start (GTK_BOX (hbox), scrolled_window, TRUE, TRUE, 0); gtk_box_pack_start (GTK_BOX (hbox), scrolled_window, TRUE, TRUE, 0);
@@ -304,19 +285,19 @@ main (int argc, char **argv)
gtk_window_set_default_size (GTK_WINDOW (dialog), 500, 300); gtk_window_set_default_size (GTK_WINDOW (dialog), 500, 300);
button = align_button_new ("Insert"); button = gtk_button_new_with_label ("Insert");
gtk_box_pack_start (GTK_BOX (button_vbox), button, FALSE, FALSE, 0); gtk_box_pack_start (GTK_BOX (button_vbox), button, FALSE, FALSE, 0);
g_signal_connect (button, "clicked", G_CALLBACK (on_insert), NULL); g_signal_connect (button, "clicked", G_CALLBACK (on_insert), NULL);
button = align_button_new ("Delete"); button = gtk_button_new_with_label ("Delete");
gtk_box_pack_start (GTK_BOX (button_vbox), button, FALSE, FALSE, 0); gtk_box_pack_start (GTK_BOX (button_vbox), button, FALSE, FALSE, 0);
g_signal_connect (button, "clicked", G_CALLBACK (on_delete), NULL); g_signal_connect (button, "clicked", G_CALLBACK (on_delete), NULL);
button = align_button_new ("Reorder"); button = gtk_button_new_with_label ("Reorder");
gtk_box_pack_start (GTK_BOX (button_vbox), button, FALSE, FALSE, 0); gtk_box_pack_start (GTK_BOX (button_vbox), button, FALSE, FALSE, 0);
g_signal_connect (button, "clicked", G_CALLBACK (on_reorder), NULL); g_signal_connect (button, "clicked", G_CALLBACK (on_reorder), NULL);
button = align_button_new ("Animate"); button = gtk_button_new_with_label ("Animate");
gtk_box_pack_start (GTK_BOX (button_vbox), button, FALSE, FALSE, 0); gtk_box_pack_start (GTK_BOX (button_vbox), button, FALSE, FALSE, 0);
g_signal_connect (button, "clicked", G_CALLBACK (on_animate), NULL); g_signal_connect (button, "clicked", G_CALLBACK (on_animate), NULL);

View File

@@ -115,7 +115,8 @@ main (int argc, char **argv)
*/ */
label = gtk_label_new ("Open File:"); label = gtk_label_new ("Open File:");
gtk_grid_attach (GTK_GRID (grid), label, 0, 0, 1, 1); gtk_grid_attach (GTK_GRID (grid), label, 0, 0, 1, 1);
gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); gtk_widget_set_halign (label, GTK_ALIGN_START);
gtk_widget_set_valign (label, GTK_ALIGN_CENTER);
entry = gtk_entry_new (); entry = gtk_entry_new ();
gtk_widget_set_hexpand (entry, TRUE); gtk_widget_set_hexpand (entry, TRUE);
@@ -146,7 +147,8 @@ main (int argc, char **argv)
*/ */
label = gtk_label_new ("Save File:"); label = gtk_label_new ("Save File:");
gtk_grid_attach (GTK_GRID (grid), label, 0, 1, 1, 1); gtk_grid_attach (GTK_GRID (grid), label, 0, 1, 1, 1);
gtk_misc_set_alignment (GTK_MISC(label), 0.0, 0.5); gtk_widget_set_halign (label, GTK_ALIGN_START);
gtk_widget_set_valign (label, GTK_ALIGN_CENTER);
entry = gtk_entry_new (); entry = gtk_entry_new ();
gtk_widget_set_hexpand (entry, TRUE); gtk_widget_set_hexpand (entry, TRUE);
@@ -181,7 +183,8 @@ main (int argc, char **argv)
*/ */
label = gtk_label_new ("Search:"); label = gtk_label_new ("Search:");
gtk_grid_attach (GTK_GRID (grid), label, 0, 2, 1, 1); gtk_grid_attach (GTK_GRID (grid), label, 0, 2, 1, 1);
gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); gtk_widget_set_halign (label, GTK_ALIGN_START);
gtk_widget_set_valign (label, GTK_ALIGN_CENTER);
entry = gtk_entry_new (); entry = gtk_entry_new ();
gtk_widget_set_hexpand (entry, TRUE); gtk_widget_set_hexpand (entry, TRUE);
@@ -207,7 +210,8 @@ main (int argc, char **argv)
*/ */
label = gtk_label_new ("Password:"); label = gtk_label_new ("Password:");
gtk_grid_attach (GTK_GRID (grid), label, 0, 3, 1, 1); gtk_grid_attach (GTK_GRID (grid), label, 0, 3, 1, 1);
gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); gtk_widget_set_halign (label, GTK_ALIGN_START);
gtk_widget_set_valign (label, GTK_ALIGN_CENTER);
entry = gtk_entry_new (); entry = gtk_entry_new ();
gtk_widget_set_hexpand (entry, TRUE); gtk_widget_set_hexpand (entry, TRUE);
@@ -230,7 +234,8 @@ main (int argc, char **argv)
/* Name - Does not set any icons. */ /* Name - Does not set any icons. */
label = gtk_label_new ("Name:"); label = gtk_label_new ("Name:");
gtk_grid_attach (GTK_GRID (grid), label, 0, 4, 1, 1); gtk_grid_attach (GTK_GRID (grid), label, 0, 4, 1, 1);
gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5); gtk_widget_set_halign (label, GTK_ALIGN_START);
gtk_widget_set_valign (label, GTK_ALIGN_CENTER);
entry = gtk_entry_new (); entry = gtk_entry_new ();
gtk_widget_set_hexpand (entry, TRUE); gtk_widget_set_hexpand (entry, TRUE);

View File

@@ -294,11 +294,6 @@ append_items_from_model (GtkWidget *menu,
gtk_widget_show (w); gtk_widget_show (w);
gtk_widget_set_sensitive (w, FALSE); gtk_widget_set_sensitive (w, FALSE);
gtk_menu_shell_append (GTK_MENU_SHELL (menu), w); gtk_menu_shell_append (GTK_MENU_SHELL (menu), w);
#if 0
/* FIXME: this interferes with toggle spacing */
w = gtk_bin_get_child (GTK_BIN (w));
gtk_misc_set_alignment (GTK_MISC (w), 0.5, 0.5);
#endif
} }
for (i = 0; i < n; i++) for (i = 0; i < n; i++)