From 7a8092998aa3f1cd7e203fccb0eb786805636531 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 5 Jun 2014 05:49:34 -0400 Subject: [PATCH] inspector: Fix a memory leak --- gtk/inspector/prop-editor.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/gtk/inspector/prop-editor.c b/gtk/inspector/prop-editor.c index f49e7209a8..752caeca99 100644 --- a/gtk/inspector/prop-editor.c +++ b/gtk/inspector/prop-editor.c @@ -24,7 +24,7 @@ struct _GtkInspectorPropEditorPrivate { GObject *object; - char *name; + gchar *name; gboolean is_child_property; GtkWidget *editor; }; @@ -583,6 +583,7 @@ unichar_changed (GObject *object, GParamSpec *pspec, gpointer data) unblock_controller (G_OBJECT (entry)); } } + static void pointer_changed (GObject *object, GParamSpec *pspec, gpointer data) { @@ -984,7 +985,6 @@ property_editor (GObject *object, g_signal_connect_swapped (button, "clicked", G_CALLBACK (object_properties), editor); - gtk_container_add (GTK_CONTAINER (prop_edit), label); gtk_container_add (GTK_CONTAINER (prop_edit), button); gtk_widget_show (label); @@ -1332,6 +1332,16 @@ constructed (GObject *object) } +static void +finalize (GObject *object) +{ + GtkInspectorPropEditor *editor = GTK_INSPECTOR_PROP_EDITOR (object); + + g_free (editor->priv->name); + + G_OBJECT_CLASS (gtk_inspector_prop_editor_parent_class)->finalize (object); +} + static void get_property (GObject *object, guint param_id, @@ -1395,6 +1405,7 @@ gtk_inspector_prop_editor_class_init (GtkInspectorPropEditorClass *klass) GObjectClass *object_class = G_OBJECT_CLASS (klass); object_class->constructed = constructed; + object_class->finalize = finalize; object_class->get_property = get_property; object_class->set_property = set_property;