From 811bb065480833fcb554b4d4b41048d19417f86f Mon Sep 17 00:00:00 2001 From: Christian Persch Date: Tue, 26 Dec 2006 14:59:28 +0000 Subject: [PATCH] Return the correct value from gtk_notebook_insert_page if the page-added 2006-12-26 Christian Persch * gtk/gtknotebook.c: (gtk_notebook_real_insert_page): Return the correct value from gtk_notebook_insert_page if the page-added handler reorders the tabs. Bug #345094. --- ChangeLog | 6 ++++++ gtk/gtknotebook.c | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 17f9fc5fd4..bec680b105 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-12-26 Christian Persch + + * gtk/gtknotebook.c: (gtk_notebook_real_insert_page): + Return the correct value from gtk_notebook_insert_page if the + page-added handler reorders the tabs. Bug #345094. + 2006-12-26 Carlos Garnacho Fix small regressions in GtkNotebook tab detaching. Bug #378852. diff --git a/gtk/gtknotebook.c b/gtk/gtknotebook.c index 23fa357cd1..e4b0eb66e4 100644 --- a/gtk/gtknotebook.c +++ b/gtk/gtknotebook.c @@ -3974,7 +3974,8 @@ gtk_notebook_real_insert_page (GtkNotebook *notebook, gtk_widget_child_notify (child, "position"); gtk_widget_thaw_child_notify (child); - return position; + /* The page-added handler might have reordered the pages, re-get the position */ + return gtk_notebook_page_num (notebook, child); } /* Private GtkNotebook Functions: