From 8443b9c787ed2a087850b403db1d4cd3959897b2 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 31 May 2006 04:06:12 +0000 Subject: [PATCH] Clarify the docs of the color-set and font-set signals. (#343438, Olexiy 2006-05-31 Matthias Clasen * gtk/gtkfontbutton.c: * gtk/gtkcolorbutton.c: Clarify the docs of the color-set and font-set signals. (#343438, Olexiy Avramchenko) --- ChangeLog | 6 ++++++ ChangeLog.pre-2-10 | 6 ++++++ gtk/gtkcolorbutton.c | 12 ++++++++---- gtk/gtkfontbutton.c | 10 +++++++--- 4 files changed, 27 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index 57190bed72..ed88625a9e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-05-31 Matthias Clasen + + * gtk/gtkfontbutton.c: + * gtk/gtkcolorbutton.c: Clarify the docs of the color-set and + font-set signals. (#343438, Olexiy Avramchenko) + 2006-05-30 Matthias Clasen * gtk/gtkmain.c (gtk_grab_notify_foreach): Don't skip internal diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 57190bed72..ed88625a9e 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,9 @@ +2006-05-31 Matthias Clasen + + * gtk/gtkfontbutton.c: + * gtk/gtkcolorbutton.c: Clarify the docs of the color-set and + font-set signals. (#343438, Olexiy Avramchenko) + 2006-05-30 Matthias Clasen * gtk/gtkmain.c (gtk_grab_notify_foreach): Don't skip internal diff --git a/gtk/gtkcolorbutton.c b/gtk/gtkcolorbutton.c index a917cd22f5..590e093dd5 100644 --- a/gtk/gtkcolorbutton.c +++ b/gtk/gtkcolorbutton.c @@ -223,9 +223,13 @@ gtk_color_button_class_init (GtkColorButtonClass *klass) * GtkColorButton::color-set: * @widget: the object which received the signal. * - * The ::color-set signal is emitted when the user selects a color. When handling this signal, - * use gtk_color_button_get_color() and gtk_color_button_get_alpha() to find out which color - * was just selected. + * The ::color-set signal is emitted when the user selects a color. + * When handling this signal, use gtk_color_button_get_color() and + * gtk_color_button_get_alpha() to find out which color was just selected. + * + * Note that this signal is only emitted when the user + * changes the color. If you need to react to programmatic color changes + * as well, use the notify::color signal. * * Since: 2.4 */ @@ -237,7 +241,7 @@ gtk_color_button_class_init (GtkColorButtonClass *klass) _gtk_marshal_VOID__VOID, G_TYPE_NONE, 0); - g_type_class_add_private (gobject_class, sizeof (GtkColorButtonPrivate)); + g_type_class_add_private (gobject_class, sizeof (GtkColorButtonPrivat; } static void diff --git a/gtk/gtkfontbutton.c b/gtk/gtkfontbutton.c index 2f1814434f..f6b6de3c77 100644 --- a/gtk/gtkfontbutton.c +++ b/gtk/gtkfontbutton.c @@ -231,9 +231,13 @@ gtk_font_button_class_init (GtkFontButtonClass *klass) * GtkFontButton::font-set: * @widget: the object which received the signal. * - * The ::font-set signal is emitted when the user selects a font. When - * handling this signal, use gtk_font_button_get_font_name() to find out - * which font was just selected. + * The ::font-set signal is emitted when the user selects a font. + * When handling this signal, use gtk_font_button_get_font_name() + * to find out which font was just selected. + * + * Note that this signal is only emitted when the user + * changes the font. If you need to react to programmatic font changes + * as well, use the notify::font-name signal. * * Since: 2.4 */