From 8493ebfe98330cd50fd80cde574baad8eec46807 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 25 Mar 2020 16:01:06 -0400 Subject: [PATCH] filechoosererrorstack: Fix object life-cycle Unparent children in dispose, not in finalize. --- gtk/gtkfilechoosererrorstack.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gtk/gtkfilechoosererrorstack.c b/gtk/gtkfilechoosererrorstack.c index 39e18c0002..9020946626 100644 --- a/gtk/gtkfilechoosererrorstack.c +++ b/gtk/gtkfilechoosererrorstack.c @@ -21,13 +21,13 @@ G_DEFINE_TYPE (GtkFileChooserErrorStack, gtk_file_chooser_error_stack, GTK_TYPE_WIDGET) static void -gtk_file_chooser_error_stack_finalize (GObject *object) +gtk_file_chooser_error_stack_dispose (GObject *object) { GtkFileChooserErrorStack *self = GTK_FILE_CHOOSER_ERROR_STACK (object); g_clear_pointer (&self->stack, gtk_widget_unparent); - G_OBJECT_CLASS (gtk_file_chooser_error_stack_parent_class)->finalize (object); + G_OBJECT_CLASS (gtk_file_chooser_error_stack_parent_class)->dispose (object); } static void @@ -36,7 +36,7 @@ gtk_file_chooser_error_stack_class_init (GtkFileChooserErrorStackClass *class) GObjectClass *object_class = G_OBJECT_CLASS (class); GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (class); - object_class->finalize = gtk_file_chooser_error_stack_finalize; + object_class->dispose = gtk_file_chooser_error_stack_dispose; gtk_widget_class_set_layout_manager_type (widget_class, GTK_TYPE_BIN_LAYOUT); }