From 873cc0e352576a6a0a9d78d49d1575b6f92453cf Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Tue, 26 May 2015 16:26:59 +0200 Subject: [PATCH] notebook: Fix assert in ::drag-motion The drag destination might be empty, we shouldn't be checking whether it contains pages at all. Instead, check the source notebook, which ought to have a selected page if you're dragging something from there. https://bugzilla.gnome.org/show_bug.cgi?id=749893 --- gtk/gtknotebook.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gtk/gtknotebook.c b/gtk/gtknotebook.c index ef27191387..9edb66c3af 100644 --- a/gtk/gtknotebook.c +++ b/gtk/gtknotebook.c @@ -3829,8 +3829,6 @@ gtk_notebook_drag_motion (GtkWidget *widget, goto out; } - g_assert (priv->cur_page != NULL); - stop_scrolling (notebook); target = gtk_drag_dest_find_target (widget, context, NULL); tab_target = gdk_atom_intern_static_string ("GTK_NOTEBOOK_TAB"); @@ -3844,6 +3842,7 @@ gtk_notebook_drag_motion (GtkWidget *widget, retval = TRUE; source = GTK_NOTEBOOK (gtk_drag_get_source_widget (context)); + g_assert (source->priv->cur_page != NULL); source_child = source->priv->cur_page->child; group = notebook->priv->group;