From 893fc1dec4d308d91412a33366ef498d6488c62c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Lindqvist?= Date: Mon, 24 Mar 2008 21:31:22 +0000 Subject: [PATCH] Range: Bin pointless check before emitting signal In scroll_event(), there is no need to check whether we are realized before emitting ::change-value, as we must be when receiving an event. Git-formatted/rebased/cleaned up by Daniel Boles Close https://gitlab.gnome.org/GNOME/gtk/issues/292 --- gtk/gtkrange.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/gtk/gtkrange.c b/gtk/gtkrange.c index 38f56630d5..317843698b 100644 --- a/gtk/gtkrange.c +++ b/gtk/gtkrange.c @@ -3107,18 +3107,12 @@ gtk_range_scroll_event (GtkWidget *widget, { GtkRange *range = GTK_RANGE (widget); GtkRangePrivate *priv = range->priv; + double delta = _gtk_range_get_wheel_delta (range, event); + gboolean handled; - if (gtk_widget_get_realized (widget)) - { - gdouble delta; - gboolean handled; - - delta = _gtk_range_get_wheel_delta (range, event); - - g_signal_emit (range, signals[CHANGE_VALUE], 0, - GTK_SCROLL_JUMP, gtk_adjustment_get_value (priv->adjustment) + delta, - &handled); - } + g_signal_emit (range, signals[CHANGE_VALUE], 0, + GTK_SCROLL_JUMP, gtk_adjustment_get_value (priv->adjustment) + delta, + &handled); return GDK_EVENT_STOP; }