From 8c4c96adc7c821ef789260cb35dc81d9b5079d0c Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Wed, 14 Sep 2005 03:13:24 +0000 Subject: [PATCH] Fix a use-after-free bug. (#316256, Alexander Nedotsukov) 2005-09-14 Matthias Clasen * gtk/updateiconcache.c (foreach_remove_func): Fix a use-after-free bug. (#316256, Alexander Nedotsukov) --- ChangeLog | 5 +++++ ChangeLog.pre-2-10 | 5 +++++ gtk/updateiconcache.c | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index a910da3651..8803121c45 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2005-09-14 Matthias Clasen + + * gtk/updateiconcache.c (foreach_remove_func): Fix + a use-after-free bug. (#316256, Alexander Nedotsukov) + 2005-09-13 Federico Mena Quintero * gtk/gtkfilechooserdefault.c: Turn off profiling for the stable diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index a910da3651..8803121c45 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,8 @@ +2005-09-14 Matthias Clasen + + * gtk/updateiconcache.c (foreach_remove_func): Fix + a use-after-free bug. (#316256, Alexander Nedotsukov) + 2005-09-13 Federico Mena Quintero * gtk/gtkfilechooserdefault.c: Turn off profiling for the stable diff --git a/gtk/updateiconcache.c b/gtk/updateiconcache.c index 468f31a759..f3385b0547 100644 --- a/gtk/updateiconcache.c +++ b/gtk/updateiconcache.c @@ -144,9 +144,9 @@ foreach_remove_func (gpointer key, gpointer value, gpointer user_data) if (image->flags == HAS_ICON_FILE) { g_free (key); - g_free (image); g_free (image->attach_points); g_strfreev (image->display_names); + g_free (image); return TRUE; }