From 90d502fdbd23b25298721d8b448d0fcd54ff85a7 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 16 Nov 2017 23:56:11 -0500 Subject: [PATCH] x11: Fix error traps in the dnd code The code for grabbing keys was using a generic error trap call, and more concerning, it was forgetting to pop the trap. --- gdk/x11/gdkdnd-x11.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gdk/x11/gdkdnd-x11.c b/gdk/x11/gdkdnd-x11.c index 222432025a..767fd1cdec 100644 --- a/gdk/x11/gdkdnd-x11.c +++ b/gdk/x11/gdkdnd-x11.c @@ -2690,7 +2690,7 @@ drag_context_grab (GdkDragContext *context) g_set_object (&x11_context->grab_seat, seat); - gdk_error_trap_push (); + gdk_x11_display_error_trap_push (context->display); for (i = 0; i < G_N_ELEMENTS (grab_keys); ++i) { @@ -2742,6 +2742,8 @@ drag_context_grab (GdkDragContext *context) } } + gdk_x11_display_error_trap_pop_ignored (context->display); + return TRUE; }