From 95f65da038c9f6615bacded2ff72bcfda1c502e7 Mon Sep 17 00:00:00 2001 From: Daniel Boles Date: Sun, 22 Apr 2018 21:17:29 +0100 Subject: [PATCH] MenuItem: Fix broken args to insert_before|after() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The widget & its parent were swapped to each other’s place in the calls. https://gitlab.gnome.org/GNOME/gtk/issues/200 --- gtk/gtkmenuitem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gtk/gtkmenuitem.c b/gtk/gtkmenuitem.c index 06867ab088..392de1e748 100644 --- a/gtk/gtkmenuitem.c +++ b/gtk/gtkmenuitem.c @@ -933,7 +933,7 @@ update_arrow_classes (GtkMenuItem *menu_item) child = gtk_widget_get_first_child (GTK_WIDGET (menu_item)); if (child != priv->arrow_widget) - gtk_widget_insert_after (GTK_WIDGET (menu_item), priv->arrow_widget, NULL); + gtk_widget_insert_after (priv->arrow_widget, GTK_WIDGET (menu_item), NULL); } else { @@ -943,7 +943,7 @@ update_arrow_classes (GtkMenuItem *menu_item) child = gtk_widget_get_last_child (GTK_WIDGET (menu_item)); if (child != priv->arrow_widget) - gtk_widget_insert_before (GTK_WIDGET (menu_item), priv->arrow_widget, NULL); + gtk_widget_insert_before (priv->arrow_widget, GTK_WIDGET (menu_item), NULL); } }