From b04a863328f2ff64462b8bbbd2f28bcfd09ec667 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Fri, 17 Mar 2017 19:56:33 -0400 Subject: [PATCH] Avoid a critical warning in the filechooser portal This was showing up when cancelling a portal file chooser in recipes. --- gtk/gtkfilechoosernativeportal.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/gtk/gtkfilechoosernativeportal.c b/gtk/gtkfilechoosernativeportal.c index 981e0d5471..45ceb3f4cf 100644 --- a/gtk/gtkfilechoosernativeportal.c +++ b/gtk/gtkfilechoosernativeportal.c @@ -110,15 +110,17 @@ response_cb (GDBusConnection *connection, choices = g_variant_lookup_value (response_data, "choices", G_VARIANT_TYPE ("a(ss)")); if (choices) - for (i = 0; i < g_variant_n_children (choices); i++) - { - const char *id; - const char *selected; - g_variant_get_child (choices, i, "(&s&s)", &id, &selected); - gtk_file_chooser_set_choice (GTK_FILE_CHOOSER (self), id, selected); - } + { + for (i = 0; i < g_variant_n_children (choices); i++) + { + const char *id; + const char *selected; + g_variant_get_child (choices, i, "(&s&s)", &id, &selected); + gtk_file_chooser_set_choice (GTK_FILE_CHOOSER (self), id, selected); + } + g_variant_unref (choices); + } - g_variant_unref (choices); g_slist_free_full (self->custom_files, g_object_unref); self->custom_files = NULL; for (i = 0; uris[i]; i++)