From b1a07731121df9cd320fd223faa496f8fe243ed7 Mon Sep 17 00:00:00 2001 From: Simon Feltman Date: Sun, 28 Jul 2013 13:16:16 -0700 Subject: [PATCH] Add explicit transfer annotations to gtk_icon_view_get_cursor The cell out argument to gtk_icon_view_get_cursor is a pass-through for gtk_cell_area_get_focus_cell which is transfer none. Without this explicit annotation, transfer full is defaulted and introspection bindings will assume ownership of the GtkIconViews reference to the cell, causing crashes. Additionally add explicit transfer full to the path parameter because it is expected the caller will free the returned memory. https://bugzilla.gnome.org/show_bug.cgi?id=704700 --- gtk/gtkiconview.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gtk/gtkiconview.c b/gtk/gtkiconview.c index 049ccce4ca..f7e9ad80fc 100644 --- a/gtk/gtkiconview.c +++ b/gtk/gtkiconview.c @@ -2209,9 +2209,10 @@ gtk_icon_view_set_cursor (GtkIconView *icon_view, /** * gtk_icon_view_get_cursor: * @icon_view: A #GtkIconView - * @path: (out) (allow-none): Return location for the current cursor path, - * or %NULL - * @cell: (out) (allow-none): Return location the current focus cell, or %NULL + * @path: (out) (allow-none) (transfer full): Return location for the current + * cursor path, or %NULL + * @cell: (out) (allow-none) (transfer none): Return location the current + * focus cell, or %NULL * * Fills in @path and @cell with the current cursor path and cell. * If the cursor isn't currently set, then *@path will be %NULL.