From b37f8b80b46f3453491f5de4df2ca1437c30582b Mon Sep 17 00:00:00 2001 From: Philip Withnall Date: Tue, 26 Nov 2013 15:06:48 +0000 Subject: [PATCH] gtkprintunixdialog: Remove a redundant (GFile != NULL) check g_file_new_for_uri() is guaranteed to return a non-NULL value, so this check was redundant, and was confusing the static analyser into returning a false positive, where it thought the file could be NULL. https://bugzilla.gnome.org/show_bug.cgi?id=712760 --- gtk/gtkprintunixdialog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gtk/gtkprintunixdialog.c b/gtk/gtkprintunixdialog.c index ea66c6703d..763775c547 100644 --- a/gtk/gtkprintunixdialog.c +++ b/gtk/gtkprintunixdialog.c @@ -659,8 +659,7 @@ error_dialogs (GtkPrintUnixDialog *print_dialog, { file = g_file_new_for_uri (option->value); - if (file != NULL && - g_file_query_exists (file, NULL)) + if (g_file_query_exists (file, NULL)) { toplevel = get_toplevel (GTK_WIDGET (print_dialog));