From b8d160c63702f24f7b73e74937a5ba1e38b090cf Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Fri, 21 Nov 2014 17:58:00 +0100 Subject: [PATCH] textview: Do not unset edition popover visibility on drag end The code here is only meant to show the popover after text selection has finished, there is no need to toggle it off here, plus it interacts with long presses. --- gtk/gtktextview.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gtk/gtktextview.c b/gtk/gtktextview.c index 5a18087b34..ab92aba62e 100644 --- a/gtk/gtktextview.c +++ b/gtk/gtktextview.c @@ -7280,10 +7280,8 @@ gtk_text_view_drag_gesture_end (GtkGestureDrag *gesture, (gtk_get_debug_flags () & GTK_DEBUG_TOUCHSCREEN) != 0 || gdk_device_get_source (device) == GDK_SOURCE_TOUCHSCREEN; - if (clicked_in_selection && priv->selection_bubble && - gtk_widget_get_visible (priv->selection_bubble)) - gtk_text_view_selection_bubble_popup_unset (text_view); - else if (!clicked_in_selection && is_touchscreen) + if (!clicked_in_selection && is_touchscreen && + (!priv->selection_bubble || !gtk_widget_get_visible (priv->selection_bubble))) gtk_text_view_selection_bubble_popup_set (text_view); if (!is_touchscreen && clicked_in_selection &&