From c30e303c3586142c84c5f72032827f15d98f43eb Mon Sep 17 00:00:00 2001
From: Matthias Clasen <matthiasc@src.gnome.org>
Date: Sat, 24 May 2008 23:19:01 +0000
Subject: [PATCH] Make the iconfactory buildable implementation less strict

svn path=/trunk/; revision=20141
---
 ChangeLog                                   | 7 +++++++
 docs/reference/gtk/tmpl/gtkiconfactory.sgml | 2 +-
 gtk/gtkiconfactory.c                        | 4 ++--
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 9045f38530..4f18934ece 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-05-24  Matthias Clasen  <mclasen@redhat.com>
+
+	Bug 520989 – icon factory buildable too strict
+
+	* gtk/gtkiconfactory.c (icon_source_start_element): Make filename
+	an optional attribute.
+
 2008-05-24  Matthias Clasen  <mclasen@redhat.com>
 
 	Bug 387972 – gtkassistant drawing problem
diff --git a/docs/reference/gtk/tmpl/gtkiconfactory.sgml b/docs/reference/gtk/tmpl/gtkiconfactory.sgml
index db160c208d..6c716e0a3b 100644
--- a/docs/reference/gtk/tmpl/gtkiconfactory.sgml
+++ b/docs/reference/gtk/tmpl/gtkiconfactory.sgml
@@ -51,7 +51,7 @@ This attribute is mandatory</para></listitem>
 <varlistentry>
 <term>filename</term>
 <listitem><para>The filename of the source, a string.
-This attribute is mandatory</para>
+This attribute is optional</para>
 </listitem>
 </varlistentry>
 
diff --git a/gtk/gtkiconfactory.c b/gtk/gtkiconfactory.c
index 7e1c7a96fa..fe932c7a16 100644
--- a/gtk/gtkiconfactory.c
+++ b/gtk/gtkiconfactory.c
@@ -2827,9 +2827,9 @@ icon_source_start_element (GMarkupParseContext *context,
 	}
     }
 
-  if (!stock_id || !filename)
+  if (!stock_id)
     {
-      error_msg = g_strdup_printf ("<source> requires a stock_id and a filename");
+      error_msg = g_strdup_printf ("<source> requires a stock_id");
       error_domain = GTK_BUILDER_ERROR_MISSING_ATTRIBUTE;
       goto error;
     }