From c3879d400c816f15a53110898bf0b2c34cab0c7d Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Tue, 17 Mar 2009 18:26:28 +0000 Subject: [PATCH] Bug 575700 - Crash when moving a GtkWindow 2009-03-17 Tor Lillqvist Bug 575700 - Crash when moving a GtkWindow * gdk/win32/gdkevents-win32.c (gdk_event_translate): Fix embarrassing crasher bug introduced on 2009-03-11. A variable was assigned a value only inside a GDK_NOTE but still used outside that. svn path=/trunk/; revision=22568 --- ChangeLog | 9 +++++++++ gdk/win32/gdkevents-win32.c | 20 ++++++++++---------- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3166e55315..aac290f2d9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2009-03-17 Tor Lillqvist + + Bug 575700 - Crash when moving a GtkWindow + + * gdk/win32/gdkevents-win32.c (gdk_event_translate): Fix + embarrassing crasher bug introduced on 2009-03-11. A variable was + assigned a value only inside a GDK_NOTE but still used outside + that. + 2009-03-17 Tor Lillqvist * gtk/gtkprintoperation-win32.c: Newer mingw-w64 uses an diff --git a/gdk/win32/gdkevents-win32.c b/gdk/win32/gdkevents-win32.c index b37fec325a..3cdd66f0e1 100644 --- a/gdk/win32/gdkevents-win32.c +++ b/gdk/win32/gdkevents-win32.c @@ -3253,16 +3253,16 @@ gdk_event_translate (MSG *msg, break; case WM_WINDOWPOSCHANGED: - GDK_NOTE (EVENTS, (windowpos = (WINDOWPOS *) msg->lParam, - g_print (" %s %s %dx%d@%+d%+d", - _gdk_win32_window_pos_bits_to_string (windowpos->flags), - (windowpos->hwndInsertAfter == HWND_BOTTOM ? "BOTTOM" : - (windowpos->hwndInsertAfter == HWND_NOTOPMOST ? "NOTOPMOST" : - (windowpos->hwndInsertAfter == HWND_TOP ? "TOP" : - (windowpos->hwndInsertAfter == HWND_TOPMOST ? "TOPMOST" : - (sprintf (buf, "%p", windowpos->hwndInsertAfter), - buf))))), - windowpos->cx, windowpos->cy, windowpos->x, windowpos->y))); + windowpos = (WINDOWPOS *) msg->lParam; + GDK_NOTE (EVENTS, g_print (" %s %s %dx%d@%+d%+d", + _gdk_win32_window_pos_bits_to_string (windowpos->flags), + (windowpos->hwndInsertAfter == HWND_BOTTOM ? "BOTTOM" : + (windowpos->hwndInsertAfter == HWND_NOTOPMOST ? "NOTOPMOST" : + (windowpos->hwndInsertAfter == HWND_TOP ? "TOP" : + (windowpos->hwndInsertAfter == HWND_TOPMOST ? "TOPMOST" : + (sprintf (buf, "%p", windowpos->hwndInsertAfter), + buf))))), + windowpos->cx, windowpos->cy, windowpos->x, windowpos->y)); /* If position and size haven't changed, don't do anything */ if (_sizemove_in_progress &&