From ca353b7fa21991ded75e47898a048bfbe2c128db Mon Sep 17 00:00:00 2001 From: Tor Lillqvist Date: Tue, 19 Nov 2002 03:24:30 +0000 Subject: [PATCH] Yes, my change on 2002-11-14 to gdkpixmap-win32.c:gdk_pixmap_new() broke 2002-11-19 Tor Lillqvist * gdk/win32/gdkwindow-win32.c (gdk_window_new): Yes, my change on 2002-11-14 to gdkpixmap-win32.c:gdk_pixmap_new() broke palettized (256-colour) display slightly: For some reason GdkWindowObject::depth of GDK_INPUT_ONLY windows now needs to be set to the visual's depth, even if the X11 backend sets it to zero. Otherwise, on a palettized display, gdk_pixmap_new() when called from gdk_window_begin_paint_region() would get zero from gdk_drawable_get_depth(), and fail. --- ChangeLog | 11 +++++++++++ ChangeLog.pre-2-10 | 11 +++++++++++ ChangeLog.pre-2-2 | 11 +++++++++++ ChangeLog.pre-2-4 | 11 +++++++++++ ChangeLog.pre-2-6 | 11 +++++++++++ ChangeLog.pre-2-8 | 11 +++++++++++ gdk/win32/gdkwindow-win32.c | 2 +- 7 files changed, 67 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 3f87f1f0bb..73fa30871e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2002-11-19 Tor Lillqvist + + * gdk/win32/gdkwindow-win32.c (gdk_window_new): Yes, my change on + 2002-11-14 to gdkpixmap-win32.c:gdk_pixmap_new() broke palettized + (256-colour) display slightly: For some reason + GdkWindowObject::depth of GDK_INPUT_ONLY windows now needs to be + set to the visual's depth, even if the X11 backend sets it to + zero. Otherwise, on a palettized display, gdk_pixmap_new() when + called from gdk_window_begin_paint_region() would get zero from + gdk_drawable_get_depth(), and fail. + 2002-11-15 Tor Lillqvist * gdk/win32/gdkprivate-win32.h diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 3f87f1f0bb..73fa30871e 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,14 @@ +2002-11-19 Tor Lillqvist + + * gdk/win32/gdkwindow-win32.c (gdk_window_new): Yes, my change on + 2002-11-14 to gdkpixmap-win32.c:gdk_pixmap_new() broke palettized + (256-colour) display slightly: For some reason + GdkWindowObject::depth of GDK_INPUT_ONLY windows now needs to be + set to the visual's depth, even if the X11 backend sets it to + zero. Otherwise, on a palettized display, gdk_pixmap_new() when + called from gdk_window_begin_paint_region() would get zero from + gdk_drawable_get_depth(), and fail. + 2002-11-15 Tor Lillqvist * gdk/win32/gdkprivate-win32.h diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index 3f87f1f0bb..73fa30871e 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,14 @@ +2002-11-19 Tor Lillqvist + + * gdk/win32/gdkwindow-win32.c (gdk_window_new): Yes, my change on + 2002-11-14 to gdkpixmap-win32.c:gdk_pixmap_new() broke palettized + (256-colour) display slightly: For some reason + GdkWindowObject::depth of GDK_INPUT_ONLY windows now needs to be + set to the visual's depth, even if the X11 backend sets it to + zero. Otherwise, on a palettized display, gdk_pixmap_new() when + called from gdk_window_begin_paint_region() would get zero from + gdk_drawable_get_depth(), and fail. + 2002-11-15 Tor Lillqvist * gdk/win32/gdkprivate-win32.h diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index 3f87f1f0bb..73fa30871e 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,14 @@ +2002-11-19 Tor Lillqvist + + * gdk/win32/gdkwindow-win32.c (gdk_window_new): Yes, my change on + 2002-11-14 to gdkpixmap-win32.c:gdk_pixmap_new() broke palettized + (256-colour) display slightly: For some reason + GdkWindowObject::depth of GDK_INPUT_ONLY windows now needs to be + set to the visual's depth, even if the X11 backend sets it to + zero. Otherwise, on a palettized display, gdk_pixmap_new() when + called from gdk_window_begin_paint_region() would get zero from + gdk_drawable_get_depth(), and fail. + 2002-11-15 Tor Lillqvist * gdk/win32/gdkprivate-win32.h diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 3f87f1f0bb..73fa30871e 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,14 @@ +2002-11-19 Tor Lillqvist + + * gdk/win32/gdkwindow-win32.c (gdk_window_new): Yes, my change on + 2002-11-14 to gdkpixmap-win32.c:gdk_pixmap_new() broke palettized + (256-colour) display slightly: For some reason + GdkWindowObject::depth of GDK_INPUT_ONLY windows now needs to be + set to the visual's depth, even if the X11 backend sets it to + zero. Otherwise, on a palettized display, gdk_pixmap_new() when + called from gdk_window_begin_paint_region() would get zero from + gdk_drawable_get_depth(), and fail. + 2002-11-15 Tor Lillqvist * gdk/win32/gdkprivate-win32.h diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 3f87f1f0bb..73fa30871e 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,14 @@ +2002-11-19 Tor Lillqvist + + * gdk/win32/gdkwindow-win32.c (gdk_window_new): Yes, my change on + 2002-11-14 to gdkpixmap-win32.c:gdk_pixmap_new() broke palettized + (256-colour) display slightly: For some reason + GdkWindowObject::depth of GDK_INPUT_ONLY windows now needs to be + set to the visual's depth, even if the X11 backend sets it to + zero. Otherwise, on a palettized display, gdk_pixmap_new() when + called from gdk_window_begin_paint_region() would get zero from + gdk_drawable_get_depth(), and fail. + 2002-11-15 Tor Lillqvist * gdk/win32/gdkprivate-win32.h diff --git a/gdk/win32/gdkwindow-win32.c b/gdk/win32/gdkwindow-win32.c index 52a14a8dbc..b11a2cbcd2 100644 --- a/gdk/win32/gdkwindow-win32.c +++ b/gdk/win32/gdkwindow-win32.c @@ -510,7 +510,7 @@ gdk_window_new (GdkWindow *parent, else { dwExStyle = WS_EX_TRANSPARENT; - private->depth = 0; + private->depth = visual->depth; private->input_only = TRUE; draw_impl->colormap = gdk_colormap_get_system (); gdk_colormap_ref (draw_impl->colormap);