From d3ad816d63814c3471fa71834a6ef68b20bba6e7 Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen@redhat.com>
Date: Mon, 22 Apr 2019 15:36:42 +0000
Subject: [PATCH 1/3] widget-factory: Add non-modal popovers

This makes is easy to test moving the toplevel
or repositioning the parent while the popover
is shown.
---
 demos/widget-factory/widget-factory.ui | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/demos/widget-factory/widget-factory.ui b/demos/widget-factory/widget-factory.ui
index 095cbdbc56..0bb77eac2e 100644
--- a/demos/widget-factory/widget-factory.ui
+++ b/demos/widget-factory/widget-factory.ui
@@ -2880,6 +2880,17 @@ microphone-sensitivity-medium-symbolic</property>
                                     <child>
                                       <object class="GtkNotebook">
                                         <property name="show-border">0</property>
+                                        <child type="action-end">
+                                          <object class="GtkMenuButton">
+                                            <property name="valign">center</property>
+                                            <property name="popover">notebook_info_popover2</property>
+                                            <property name="icon-name">emblem-important-symbolic</property>
+                                            <property name="relief">none</property>
+                                            <style>
+                                              <class name="circular"/>
+                                            </style>
+                                          </object>
+                                        </child>
                                         <child>
                                           <object class="GtkNotebookPage">
                                             <property name="tab-expand">1</property>
@@ -3439,8 +3450,9 @@ bad things might happen.</property>
     </widgets>
   </object>
   <object class="GtkPopover" id="notebook_info_popover">
+    <property name="modal">0</property>
     <child>
-      <object class="GtkLabel" id="notebook_info_label">
+      <object class="GtkLabel">
         <property name="label">No updates at this time</property>
         <accessibility>
           <role type="static"/>
@@ -3448,4 +3460,15 @@ bad things might happen.</property>
       </object>
     </child>
   </object>
+  <object class="GtkPopover" id="notebook_info_popover2">
+    <property name="modal">0</property>
+    <child>
+      <object class="GtkLabel">
+        <property name="label">No updates here either</property>
+        <accessibility>
+          <role type="static"/>
+        </accessibility>
+      </object>
+    </child>
+  </object>
 </interface>

From e1200230c4379fe555b20cf47ef11676262d4af1 Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen@redhat.com>
Date: Tue, 23 Apr 2019 19:00:44 +0000
Subject: [PATCH 2/3] widget-factory: Add some nested popovers

These are mainly for stress-testing our
popover implementations.
---
 demos/widget-factory/widget-factory.ui | 45 +++++++++++++++++++++++---
 1 file changed, 41 insertions(+), 4 deletions(-)

diff --git a/demos/widget-factory/widget-factory.ui b/demos/widget-factory/widget-factory.ui
index 0bb77eac2e..d0994aad58 100644
--- a/demos/widget-factory/widget-factory.ui
+++ b/demos/widget-factory/widget-factory.ui
@@ -3397,6 +3397,7 @@ bad things might happen.</property>
             <layout>
               <property name="left-attach">1</property>
               <property name="top-attach">1</property>
+              <property name="column-span">2</property>
             </layout>
           </object>
         </child>
@@ -3409,12 +3410,24 @@ bad things might happen.</property>
             <layout>
               <property name="left-attach">1</property>
               <property name="top-attach">0</property>
+              <property name="column-span">2</property>
+            </layout>
+          </object>
+        </child>
+        <child>
+          <object class="GtkMenuButton">
+            <property name="halign">end</property>
+            <property name="icon-name">emblem-system-symbolic</property>
+            <property name="menu-model">gear_menu</property>
+            <layout>
+              <property name="left-attach">1</property>
+              <property name="top-attach">2</property>
             </layout>
           </object>
         </child>
         <child>
           <object class="GtkButton" id="open_popover_button">
-            <property name="halign">end</property>
+            <property name="halign">fill</property>
             <property name="label">_Open</property>
             <property name="use-underline">1</property>
             <property name="sensitive">0</property>
@@ -3423,7 +3436,7 @@ bad things might happen.</property>
               <class name="suggested-action"/>
             </style>
             <layout>
-              <property name="left-attach">1</property>
+              <property name="left-attach">2</property>
               <property name="top-attach">2</property>
             </layout>
           </object>
@@ -3460,15 +3473,39 @@ bad things might happen.</property>
       </object>
     </child>
   </object>
-  <object class="GtkPopover" id="notebook_info_popover2">
+  <object class="GtkPopover" id="notebook_info_popover3">
     <property name="modal">0</property>
     <child>
       <object class="GtkLabel">
-        <property name="label">No updates here either</property>
+        <property name="label">You're in too deep!</property>
         <accessibility>
           <role type="static"/>
         </accessibility>
       </object>
     </child>
   </object>
+  <object class="GtkPopover" id="notebook_info_popover2">
+    <property name="modal">0</property>
+    <child>
+      <object class="GtkBox">
+        <property name="orientation">horizontal</property>
+        <child>
+          <object class="GtkLabel">
+            <property name="label">Hidden gems:</property>
+          </object>
+        </child>
+        <child>
+          <object class="GtkMenuButton">
+            <property name="valign">center</property>
+            <property name="popover">notebook_info_popover3</property>
+            <property name="icon-name">emblem-important-symbolic</property>
+            <property name="relief">none</property>
+            <style>
+              <class name="circular"/>
+            </style>
+          </object>
+        </child>
+      </object>
+    </child>
+  </object>
 </interface>

From aab803b7ae77935c03d7e943c21654632ce63ad7 Mon Sep 17 00:00:00 2001
From: Matthias Clasen <mclasen@redhat.com>
Date: Sat, 27 Apr 2019 18:00:22 +0000
Subject: [PATCH 3/3] widget-factory: Make a resizing popover

Add an expander to a popover to test how
changing sizes works with popovers.
---
 demos/widget-factory/widget-factory.ui | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/demos/widget-factory/widget-factory.ui b/demos/widget-factory/widget-factory.ui
index d0994aad58..781d934668 100644
--- a/demos/widget-factory/widget-factory.ui
+++ b/demos/widget-factory/widget-factory.ui
@@ -3414,6 +3414,25 @@ bad things might happen.</property>
             </layout>
           </object>
         </child>
+        <child>
+          <object class="GtkExpander">
+            <child type="label">
+              <object class="GtkLabel">
+                <property name="label">Extra Info</property>
+              </object>
+            </child>
+            <child>
+              <object class="GtkEntry">
+                <property name="placeholder-text">Tell me anything…</property>
+              </object>
+            </child>
+            <layout>
+              <property name="left-attach">1</property>
+              <property name="top-attach">2</property>
+              <property name="column-span">2</property>
+            </layout>
+          </object>
+        </child>
         <child>
           <object class="GtkMenuButton">
             <property name="halign">end</property>
@@ -3421,7 +3440,7 @@ bad things might happen.</property>
             <property name="menu-model">gear_menu</property>
             <layout>
               <property name="left-attach">1</property>
-              <property name="top-attach">2</property>
+              <property name="top-attach">3</property>
             </layout>
           </object>
         </child>
@@ -3437,7 +3456,7 @@ bad things might happen.</property>
             </style>
             <layout>
               <property name="left-attach">2</property>
-              <property name="top-attach">2</property>
+              <property name="top-attach">3</property>
             </layout>
           </object>
         </child>