From e9300e2f7917dd67c8adc8c08390c44ca22f0d9b Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sat, 20 Feb 2016 22:43:43 -0500 Subject: [PATCH] dnd: Avoid a crash gtk_image_definition_new_icon_name ("") returns NULL. Bail out early in this case to avoid unreffing NULL later. https://bugzilla.gnome.org/show_bug.cgi?id=762392 --- gtk/gtkdnd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/gtkdnd.c b/gtk/gtkdnd.c index e00aab28ae..48be48c355 100644 --- a/gtk/gtkdnd.c +++ b/gtk/gtkdnd.c @@ -2857,7 +2857,7 @@ gtk_drag_set_icon_name (GdkDragContext *context, GtkImageDefinition *def; g_return_if_fail (GDK_IS_DRAG_CONTEXT (context)); - g_return_if_fail (icon_name != NULL); + g_return_if_fail (icon_name != NULL && icon_name[0] != '\0'); def = gtk_image_definition_new_icon_name (icon_name); set_icon_helper (context, def, hot_x, hot_y);