From e9c9d1d0a04acc566d93f91f50688ce2ff1ba6f3 Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Sun, 3 Nov 2024 02:44:02 +0100 Subject: [PATCH] filechooser: Use g_clear_object() on potentially NULL objects We can reach here in early exit paths when the shortcut_files have not been initialized yet. --- gtk/gtkfilechoosernativewin32.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gtk/gtkfilechoosernativewin32.c b/gtk/gtkfilechoosernativewin32.c index bfa4dadcf0..01164d357b 100644 --- a/gtk/gtkfilechoosernativewin32.c +++ b/gtk/gtkfilechoosernativewin32.c @@ -333,10 +333,9 @@ filechooser_win32_thread_data_free (FilechooserWin32ThreadData *data) g_array_free (data->choices_selections, TRUE); data->choices_selections = NULL; } - g_object_unref (data->shortcut_files); + g_clear_object (&data->shortcut_files); g_slist_free_full (data->files, g_object_unref); - if (data->self) - g_object_unref (data->self); + g_clear_object (&data->self); g_free (data->accept_label); g_free (data->cancel_label); g_free (data->title);