From f1cadee19613c8fcc0fa7d6b35e017919a2dab82 Mon Sep 17 00:00:00 2001 From: Emmanuele Bassi Date: Fri, 22 Mar 2019 12:38:36 +0000 Subject: [PATCH] Use matrix equality in GskTransform Graphene has new API to check for equality, so we should use it instead of doing a byte-by-byte comparison. --- gsk/gsktransform.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gsk/gsktransform.c b/gsk/gsktransform.c index 428132bdfb..ebd9980832 100644 --- a/gsk/gsktransform.c +++ b/gsk/gsktransform.c @@ -419,8 +419,10 @@ gsk_matrix_transform_equal (GskTransform *first_transform, GskMatrixTransform *first = (GskMatrixTransform *) first_transform; GskMatrixTransform *second = (GskMatrixTransform *) second_transform; - /* Crude, but better than just returning FALSE */ - return memcmp (&first->matrix, &second->matrix, sizeof (graphene_matrix_t)) == 0; + if (graphene_matrix_equal_fast (&first->matrix, &second->matrix)) + return TRUE; + + return graphene_matrix_equal (&first->matrix, &second->matrix); } static const GskTransformClass GSK_TRANSFORM_TRANSFORM_CLASS =