Add a comment

This is something that wasn't clear to me, and it
is important to know to understand how we are handling
(un)premultiplication here.

gdk/gdkgltexture.c

@@ -171,13 +171,21 @@ gdk_gl_texture_do_download (GdkGLTexture *self,
   Download *download = download_;
   GLenum gl_internal_format, gl_format, gl_type;
   int major, minor;
+  unsigned int internal_texture_format, dummy;
 
   expected_stride = texture->width * gdk_memory_format_bytes_per_pixel (download->format);
   gdk_gl_context_get_version (context, &major, &minor);
 
+  gdk_memory_format_gl_format (gdk_texture_get_format (texture),
+                               FALSE,
+                               major, minor,
+                               &internal_texture_format,
+                               &dummy, &dummy);
+
   if (download->stride == expected_stride &&
       !gdk_gl_context_get_use_es (context) &&
-      gdk_memory_format_gl_format (download->format, TRUE, major, minor, &gl_internal_format, &gl_format, &gl_type))
+      gdk_memory_format_gl_format (download->format, FALSE, major, minor, &gl_internal_format, &gl_format, &gl_type) &&
+      gl_internal_format == internal_texture_format)
     {
       glGetTexImage (GL_TEXTURE_2D,
                      0,

gdk/gdkmemoryformat.c

@@ -600,6 +600,11 @@ gdk_memory_convert (guchar              *dest_data,
   for (y = 0; y < height; y++)
     {
       src_desc->to_float (tmp, src_data, width);
+
+      /* Note: Converting from a premultiplied format to an opaque format is defined
+       * to yield the same result as compositing over black, which works out to
+       * using the premultiplied values, and just dropping alpha.
+       */
       if (src_desc->alpha == GDK_MEMORY_ALPHA_PREMULTIPLIED && dest_desc->alpha == GDK_MEMORY_ALPHA_STRAIGHT)
         unpremultiply (tmp, width);
       else if (src_desc->alpha == GDK_MEMORY_ALPHA_STRAIGHT && dest_desc->alpha != GDK_MEMORY_ALPHA_STRAIGHT)

gdk/win32/gdkdisplay-win32.c

@@ -292,6 +292,7 @@ _gdk_win32_display_init_monitors (GdkWin32Display *win32_display)
       if (!w32_ex_monitor->remove)
         continue;
 
+      w32_ex_monitor->hmonitor = NULL;
       g_list_store_remove (G_LIST_STORE (win32_display->monitors), i);
       gdk_monitor_invalidate (ex_monitor);
     }

gdk/win32/gdkmonitor-win32.c

@@ -443,9 +443,6 @@ populate_monitor_devices_from_display_config (GPtrArray *monitors)
       char *path, *path_lower;
       DISPLAYCONFIG_RATIONAL *refresh;
 
-      if ((dispconf_paths[path_index].flags & DISPLAYCONFIG_PATH_ACTIVE) == 0)
-        continue;
-
       tdn.header.type = DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_NAME;
       tdn.header.size = sizeof (tdn);
       tdn.header.adapterId = dispconf_paths[path_index].targetInfo.adapterId;
@@ -481,6 +478,12 @@ populate_monitor_devices_from_display_config (GPtrArray *monitors)
       if (w32mon == NULL)
         continue;
 
+      if ((dispconf_paths[path_index].flags & DISPLAYCONFIG_PATH_ACTIVE) == 0)
+        {
+          w32mon->remove = TRUE;
+          continue;
+        }
+
       mon = GDK_MONITOR (w32mon);
 
       if (!tdn.flags.friendlyNameForced)
@@ -598,6 +601,8 @@ enum_monitor (HMONITOR hmonitor,
 
               if (w32mon == NULL)
                 continue;
+
+              w32mon->hmonitor = hmonitor;
             }
           else
             {

gdk/win32/gdkmonitor-win32.h

@@ -35,6 +35,9 @@ struct _GdkWin32Monitor
   /* Device instance path (used to match GdkWin32Monitor to monitor device) */
   char *instance_path;
 
+  /* MOnitor handle (used to fullscreen windows on monitors) */
+  HMONITOR hmonitor;
+
   /* TRUE if monitor is made up by us
    * (this happens when system has logical monitors, but no physical ones).
    */

gdk/win32/gdksurface-win32.c

@@ -50,6 +50,7 @@
 #include "gdkdisplay-win32.h"
 #include "gdkdevice-win32.h"
 #include "gdkcairocontext-win32.h"
+#include "gdkmonitor-win32.h"
 
 #include <cairo-win32.h>
 #include <dwmapi.h>
@@ -625,7 +626,8 @@ get_outer_rect (GdkSurface *window,
 }
 
 static void
-gdk_win32_surface_fullscreen (GdkSurface *window);
+gdk_win32_surface_fullscreen (GdkSurface *window,
+                              GdkMonitor *monitor);
 
 static void
 show_window_internal (GdkSurface *window,
@@ -789,11 +791,7 @@ show_window_internal (GdkSurface *window,
     }
 
 
-  if (window->state & GDK_TOPLEVEL_STATE_FULLSCREEN)
+  if (window->state & GDK_TOPLEVEL_STATE_MAXIMIZED)
-    {
-      gdk_win32_surface_fullscreen (window);
-    }
-  else if (window->state & GDK_TOPLEVEL_STATE_MAXIMIZED)
     {
       GtkShowWindow (window, SW_MAXIMIZE);
     }
@@ -4008,11 +4006,12 @@ gdk_win32_surface_unmaximize (GdkSurface *surface)
 }
 
 static void
-gdk_win32_surface_fullscreen (GdkSurface *window)
+gdk_win32_surface_fullscreen (GdkSurface *window,
+                              GdkMonitor *monitor)
 {
   int x, y, width, height;
   FullscreenInfo *fi;
-  HMONITOR monitor;
+  HMONITOR hmonitor = NULL;
   MONITORINFO mi;
 
   g_return_if_fail (GDK_IS_SURFACE (window));
@@ -4025,9 +4024,14 @@ gdk_win32_surface_fullscreen (GdkSurface *window)
     {
       GdkWin32Surface *impl = GDK_WIN32_SURFACE (window);
 
-      monitor = MonitorFromWindow (GDK_SURFACE_HWND (window), MONITOR_DEFAULTTONEAREST);
+      if (monitor && GDK_IS_WIN32_MONITOR (monitor))
+        hmonitor = GDK_WIN32_MONITOR (monitor)->hmonitor;
+
+      if (!hmonitor)
+        hmonitor = MonitorFromWindow (GDK_SURFACE_HWND (window), MONITOR_DEFAULTTONEAREST);
+
       mi.cbSize = sizeof (mi);
-      if (monitor && GetMonitorInfo (monitor, &mi))
+      if (hmonitor && GetMonitorInfo (hmonitor, &mi))
 	{
 	  x = mi.rcMonitor.left;
 	  y = mi.rcMonitor.top;
@@ -4869,9 +4873,16 @@ gdk_win32_toplevel_present (GdkToplevel       *toplevel,
   if (gdk_toplevel_layout_get_fullscreen (layout, &fullscreen))
     {
       if (fullscreen)
-        gdk_win32_surface_fullscreen (surface);
+        {
+          GdkMonitor *monitor;
+
+          monitor = gdk_toplevel_layout_get_fullscreen_monitor (layout);
+          gdk_win32_surface_fullscreen (surface, monitor);
+        }
       else
-        gdk_win32_surface_unfullscreen (surface);
+        {
+          gdk_win32_surface_unfullscreen (surface);
+        }
     }
 
   gdk_win32_surface_show (surface, FALSE);

gsk/gl/gskglcommandqueue.c

@@ -1447,6 +1447,7 @@ gsk_gl_command_queue_create_framebuffer (GskGLCommandQueue *self)
   return fbo_id;
 }
 
+
 static GdkMemoryFormat
 memory_format_gl_format (GdkMemoryFormat  data_format,
                          gboolean         use_es,
@@ -1611,13 +1612,13 @@ gsk_gl_command_queue_upload_texture_chunks (GskGLCommandQueue    *self,
   use_es = gdk_gl_context_get_use_es (self->context);
   gdk_gl_context_get_version (self->context, &major, &minor);
   data_format = gdk_texture_get_format (chunks[0].texture);
-  memory_format_gl_format (data_format,
+  data_format = memory_format_gl_format (data_format,
-                           use_es,
+                                         use_es,
-                           major,
+                                         major,
-                           minor,
+                                         minor,
-                           &gl_internalformat,
+                                         &gl_internalformat,
-                           &gl_format,
+                                         &gl_format,
-                           &gl_type);
+                                         &gl_type);
 
   glTexImage2D (GL_TEXTURE_2D, 0, gl_internalformat, width, height, 0, gl_format, gl_type, NULL);
 

gtk/gtkenums.h

@@ -1422,7 +1422,7 @@ typedef enum {
   GTK_ACCESSIBLE_ROLE_TREE_ITEM,
   GTK_ACCESSIBLE_ROLE_WIDGET,
   GTK_ACCESSIBLE_ROLE_WINDOW,
-  GTK_ACCESSIBLE_ROLE_TOGGLE_BUTTON
+  GTK_ACCESSIBLE_ROLE_TOGGLE_BUTTON GDK_AVAILABLE_ENUMERATOR_IN_4_10
 } GtkAccessibleRole;
 
 /**
@@ -1449,7 +1449,8 @@ typedef enum {
  * @GTK_ACCESSIBLE_STATE_SELECTED: A “selected” state; set when a widget
  *   is selected. Value type: boolean or undefined
  * @GTK_ACCESSIBLE_STATE_VISITED: Indicates that a widget with the
- * GTK_ACCESSIBLE_ROLE_LINK has been visited. Value type: boolean. Since: 4.12
+ *   GTK_ACCESSIBLE_ROLE_LINK has been visited. Value type: boolean.
+ *   Since: 4.12
  *
  * The possible accessible states of a [iface@Accessible].
  */
@@ -1462,7 +1463,7 @@ typedef enum {
   GTK_ACCESSIBLE_STATE_INVALID,
   GTK_ACCESSIBLE_STATE_PRESSED,
   GTK_ACCESSIBLE_STATE_SELECTED,
-  GTK_ACCESSIBLE_STATE_VISITED
+  GTK_ACCESSIBLE_STATE_VISITED GDK_AVAILABLE_ENUMERATOR_IN_4_12
 } GtkAccessibleState;
 
 /**

gtk/gtkgridview.c

@@ -19,18 +19,16 @@
 
 #include "config.h"
 
-#include "gtkgridviewprivate.h"
+#include "gtkgridview.h"
 
 #include "gtkbitset.h"
 #include "gtklistbaseprivate.h"
-#include "gtklistheaderwidgetprivate.h"
 #include "gtklistitemfactory.h"
 #include "gtklistitemmanagerprivate.h"
 #include "gtklistitemwidgetprivate.h"
 #include "gtkmultiselection.h"
 #include "gtktypebuiltins.h"
 #include "gtkwidgetprivate.h"
-#include "gtksectionmodel.h"
 
 /* Maximum number of list items created by the gridview.
  * For debugging, you can set this to G_MAXUINT to ensure
@@ -89,7 +87,6 @@ struct _GtkGridView
 
   GtkListItemManager *item_manager;
   GtkListItemFactory *factory;
-  GtkListItemFactory *header_factory;
   guint min_columns;
   guint max_columns;
   gboolean single_click_activate;
@@ -108,7 +105,6 @@ enum
   PROP_0,
   PROP_ENABLE_RUBBERBAND,
   PROP_FACTORY,
-  PROP_HEADER_FACTORY,
   PROP_MAX_COLUMNS,
   PROP_MIN_COLUMNS,
   PROP_MODEL,
@@ -261,13 +257,6 @@ gtk_grid_view_split (GtkListBase *base,
   return split;
 }
 
-static void
-gtk_grid_view_prepare_section (GtkListBase *base,
-                               GtkListTile *tile,
-                               guint        position)
-{
-}
-
 /* We define the listview as **inert** when the factory isn't used. */
 static gboolean
 gtk_grid_view_is_inert (GtkGridView *self)
@@ -280,8 +269,7 @@ gtk_grid_view_is_inert (GtkGridView *self)
 
 static void
 gtk_grid_view_update_factories_with (GtkGridView        *self,
-                                     GtkListItemFactory *factory,
+                                     GtkListItemFactory *factory)
-                                     GtkListItemFactory *header_factory)
 {
   GtkListTile *tile;
 
@@ -289,26 +277,8 @@ gtk_grid_view_update_factories_with (GtkGridView        *self,
        tile != NULL;
        tile = gtk_rb_tree_node_get_next (tile))
     {
-      switch (tile->type)
+      if (tile->widget)
-        {
+        gtk_list_factory_widget_set_factory (GTK_LIST_FACTORY_WIDGET (tile->widget), factory);
-        case GTK_LIST_TILE_ITEM:
-          if (tile->widget)
-            gtk_list_factory_widget_set_factory (GTK_LIST_FACTORY_WIDGET (tile->widget), factory);
-          break;
-        case GTK_LIST_TILE_HEADER:
-          if (tile->widget)
-            gtk_list_header_widget_set_factory (GTK_LIST_HEADER_WIDGET (tile->widget), header_factory);
-          break;
-        case GTK_LIST_TILE_UNMATCHED_HEADER:
-        case GTK_LIST_TILE_FOOTER:
-        case GTK_LIST_TILE_UNMATCHED_FOOTER:
-        case GTK_LIST_TILE_REMOVED:
-          g_assert (tile->widget == NULL);
-          break;
-        default:
-          g_assert_not_reached();
-          break;
-        }
     }
 }
 
@@ -316,14 +286,13 @@ static void
 gtk_grid_view_update_factories (GtkGridView *self)
 {
   gtk_grid_view_update_factories_with (self,
-                                       gtk_grid_view_is_inert (self) ? NULL : self->factory,
+                                       gtk_grid_view_is_inert (self) ? NULL : self->factory);
-                                       gtk_grid_view_is_inert (self) ? NULL : self->header_factory);
 }
 
 static void
 gtk_grid_view_clear_factories (GtkGridView *self)
 {
-  gtk_grid_view_update_factories_with (self, NULL, NULL);
+  gtk_grid_view_update_factories_with (self, NULL);
 }
 
 static GtkListItemBase *
@@ -347,20 +316,6 @@ gtk_grid_view_create_list_widget (GtkListBase *base)
   return GTK_LIST_ITEM_BASE (result);
 }
 
-static GtkListHeaderBase *
-gtk_grid_view_create_header_widget (GtkListBase *base)
-{
-  GtkGridView *self = GTK_GRID_VIEW (base);
-  GtkListItemFactory *factory;
-
-  if (gtk_grid_view_is_inert (self))
-    factory = NULL;
-  else
-    factory = self->header_factory;
-
-  return GTK_LIST_HEADER_BASE (gtk_list_header_widget_new (factory));
-}
-
 static gboolean
 gtk_grid_view_get_allocation (GtkListBase  *base,
                               guint         pos,
@@ -429,78 +384,6 @@ gtk_grid_view_get_allocation (GtkListBase  *base,
   return TRUE;
 }
 
-/* Returns the section that position falls into
- */
-void
-gtk_grid_view_get_section_for_position (GtkListItemManager *items,
-                                        unsigned int        position,
-                                        unsigned int       *section_start,
-                                        unsigned int       *section_end)
-{
-  GListModel *model;
-  unsigned int start, end;
-
-  model = G_LIST_MODEL (gtk_list_item_manager_get_model (items));
-
-  if (!gtk_list_item_manager_get_has_sections (items))
-    {
-      start = 0;
-      end = g_list_model_get_n_items (model);
-    }
-  else
-    {
-      gtk_section_model_get_section (GTK_SECTION_MODEL (model), position, &start, &end);
-    }
-
-  if (section_start)
-    *section_start = start;
-  if (section_end)
-    *section_end = end;
-}
-
-/* Returns the column that the given item will fall in, taking
- * sections into account. Note that this depends on whether
- * we are currently showing sections, and on the number of
- * columns that the grid is allocating.
- */
-unsigned int
-gtk_grid_view_get_column_for_position (GtkListItemManager *items,
-                                       unsigned int        n_columns,
-                                       unsigned int        position)
-{
-  unsigned int start;
-
-  gtk_grid_view_get_section_for_position (items, position, &start, NULL);
-
-  return (position - start) % n_columns;
-}
-
-/* Determine whether a tile is contained in a single row,
- * or spans multiple rows.
- */
-gboolean
-gtk_grid_view_is_multirow_tile (GtkListItemManager *items,
-                                unsigned int        n_columns,
-                                GtkListTile        *tile)
-{
-  unsigned int position;
-  unsigned int start, end;
-  unsigned int col;
-
-  if (tile->n_items <= 1)
-    return FALSE;
-
-  position = gtk_list_tile_get_position (items, tile);
-  gtk_grid_view_get_section_for_position (items, position, &start, &end);
-
-  if (end < position + tile->n_items)
-    return TRUE;
-
-  col = (position - start) % n_columns;
-
-  return col + tile->n_items > n_columns;
-}
-
 static gboolean
 gtk_grid_view_get_position_from_allocation (GtkListBase           *base,
                                             int                    x,
@@ -511,7 +394,6 @@ gtk_grid_view_get_position_from_allocation (GtkListBase           *base,
   GtkGridView *self = GTK_GRID_VIEW (base);
   GtkListTile *tile;
   guint pos;
-  guint col;
 
   tile = gtk_list_item_manager_get_nearest_tile (self->item_manager, x, y);
   if (tile == NULL)
@@ -529,43 +411,44 @@ gtk_grid_view_get_position_from_allocation (GtkListBase           *base,
     }
 
   pos = gtk_list_tile_get_position (self->item_manager, tile);
-  col = gtk_grid_view_get_column_for_position (self->item_manager, self->n_columns, pos);
-
   if (tile->n_items > 1)
     {
       int xspacing, yspacing;
-      unsigned int row_height;
-      unsigned int row_index;
 
       gtk_list_base_get_border_spacing (base, &xspacing, &yspacing);
 
       /* offset in x direction */
       pos += column_index (self, xspacing, MAX (tile->area.width - 1, x - tile->area.x));
+      if (area)
+        {
+          guint col = MIN (column_index (self, xspacing, x), self->n_columns - 1);
+          area->x = column_start (self, xspacing, col);
+          area->width = column_end (self, xspacing, col) - area->x;
+        }
 
       /* offset in y direction */
       if (tile->n_items > self->n_columns)
         {
           guint rows_in_tile = tile->n_items / self->n_columns;
-
+          guint row_height = (tile->area.height + yspacing) / rows_in_tile - yspacing;
-          row_height = (tile->area.height + yspacing) / rows_in_tile - yspacing;
+          guint row_index = MIN (tile->area.height - 1, y - tile->area.y) / (row_height + yspacing);
-          row_index = MIN (tile->area.height - 1, y - tile->area.y) / (row_height + yspacing);
           pos += self->n_columns * row_index;
+
+          if (area)
+            {
+              area->y = tile->area.y  + row_index * (row_height + yspacing);
+              area->height = row_height;
+            }
         }
       else
         {
-          row_height = tile->area.height;
+          if (area)
-          row_index = 0;
+            {
+              area->y = tile->area.y;
+              area->height = tile->area.height;
+            }
         }
 
-      col = gtk_grid_view_get_column_for_position (self->item_manager, self->n_columns, pos);
-
-      if (area)
-        {
-          area->x = column_start (self, xspacing, col);
-          area->y = tile->area.y  + row_index * (row_height + yspacing);
-          area->width = column_end (self, xspacing, col) - area->x;
-          area->height = row_height;
-        }
     }
   else
     {
@@ -607,104 +490,38 @@ gtk_grid_view_get_items_in_rect (GtkListBase        *base,
   if (area.y >= rect->y + rect->height)
     last_row -= self->n_columns;
 
-  if (gtk_list_item_manager_get_has_sections (self->item_manager))
+  if (first_column <= last_column && first_row <= last_row)
     {
-      for (unsigned int pos = first_row; pos < last_row + self->n_columns; pos++)
+      gtk_bitset_add_rectangle (result,
-        {
+                                first_row + first_column,
-          unsigned int col;
+                                last_column - first_column + 1,
-
+                                (last_row - first_row) / self->n_columns + 1,
-          col = gtk_grid_view_get_column_for_position (self->item_manager,
+                                self->n_columns);
-                                                       self->n_columns,
-                                                       pos);
-          if (col >= first_column && col <= last_column)
-            gtk_bitset_add (result, pos);
-        }
-    }
-  else
-    {
-      if (first_column <= last_column && first_row <= last_row)
-        {
-          gtk_bitset_add_rectangle (result,
-                                    first_row + first_column,
-                                    last_column - first_column + 1,
-                                    (last_row - first_row) / self->n_columns + 1,
-                                    self->n_columns);
-        }
     }
 
   return result;
 }
 
-static unsigned int
-find_previous_item_in_column (GtkGridView  *self,
-                              unsigned int  position)
-{
-  unsigned int col, pos;
-
-  if (position == 0)
-    return position;
-
-  col = gtk_grid_view_get_column_for_position (self->item_manager,
-                                               self->n_columns,
-                                               position);
-
-  pos = position;
-  do
-    {
-      pos--;
-
-      if (col == gtk_grid_view_get_column_for_position (self->item_manager,
-                                                        self->n_columns,
-                                                        pos))
-        return pos;
-
-    } while (pos > 0);
-
-  return position;
-}
-
-static unsigned int
-find_next_item_in_column (GtkGridView  *self,
-                          unsigned int  position)
-{
-  unsigned int col;
-  unsigned int n_items;
-
-  n_items = g_list_model_get_n_items (G_LIST_MODEL (gtk_list_item_manager_get_model (self->item_manager)));
-
-  col = gtk_grid_view_get_column_for_position (self->item_manager,
-                                               self->n_columns,
-                                               position);
-
-  for (unsigned int p = position + 1; p < n_items; p++)
-    {
-      if (col == gtk_grid_view_get_column_for_position (self->item_manager,
-                                                        self->n_columns,
-                                                        p))
-        return p;
-    }
-
-  return position;
-}
-
 static guint
 gtk_grid_view_move_focus_along (GtkListBase *base,
                                 guint        pos,
                                 int          steps)
 {
   GtkGridView *self = GTK_GRID_VIEW (base);
-  unsigned int prev_pos = pos;
 
-  for (unsigned int i = 0; i < abs (steps); i++)
+  steps *= self->n_columns;
+
+  if (steps < 0)
     {
-      if (steps < 0)
+      if (pos >= self->n_columns)
-        pos = find_previous_item_in_column (self, pos);
+        pos -= MIN (pos, -steps);
-      else
+    }
-        pos = find_next_item_in_column (self, pos);
+  else
+    {
+      guint n_items = gtk_list_base_get_n_items (base);
+      if (n_items / self->n_columns > pos / self->n_columns)
+        pos += MIN (n_items - pos - 1, steps);
     }
-
-  if (prev_pos == pos)
-    gtk_widget_keynav_failed (GTK_WIDGET (self), steps < 0 ? GTK_DIR_UP : GTK_DIR_DOWN);
 
   return pos;
 }
@@ -714,19 +531,14 @@ gtk_grid_view_move_focus_across (GtkListBase *base,
                                  guint        pos,
                                  int          steps)
 {
-  unsigned int prev_pos = pos;
-
   if (steps < 0)
-    pos = pos - MIN (pos, -steps);
+    return pos - MIN (pos, -steps);
   else
     {
       guint n_items = gtk_list_base_get_n_items (base);
       pos += MIN (n_items - pos - 1, steps);
     }
 
-  if (prev_pos == pos)
-    gtk_widget_keynav_failed (GTK_WIDGET (base), steps < 0 ? GTK_DIR_LEFT : GTK_DIR_RIGHT);
-
   return pos;
 }
 
@@ -752,49 +564,32 @@ gtk_grid_view_get_unknown_row_size (GtkGridView *self,
 static void
 gtk_grid_view_measure_column_size (GtkGridView *self,
                                    int         *minimum,
-                                   int         *natural,
+                                   int         *natural)
-                                   int         *header_minimum,
-                                   int         *header_natural)
 {
   GtkOrientation opposite;
   GtkListTile *tile;
-  int min, nat, header_min, header_nat;
+  int min, nat, child_min, child_nat;
 
   min = 0;
   nat = 0;
-  header_min = 0;
-  header_nat = 0;
   opposite = gtk_list_base_get_opposite_orientation (GTK_LIST_BASE (self));
 
   for (tile = gtk_list_item_manager_get_first (self->item_manager);
        tile != NULL;
        tile = gtk_rb_tree_node_get_next (tile))
     {
-      int child_min, child_nat;
-
       if (tile->widget == NULL)
         continue;
 
       gtk_widget_measure (tile->widget,
                           opposite, -1,
                           &child_min, &child_nat, NULL, NULL);
-
+      min = MAX (min, child_min);
-      if (tile->type == GTK_LIST_TILE_ITEM)
+      nat = MAX (nat, child_nat);
-        {
-          min = MAX (min, child_min);
-          nat = MAX (nat, child_nat);
-        }
-      else
-        {
-          header_min = MAX (header_min, child_min);
-          header_nat = MAX (header_nat, child_nat);
-        }
     }
 
   *minimum = min;
   *natural = nat;
-  *header_minimum = header_min;
-  *header_natural = header_nat;
 }
 
 static void
@@ -805,14 +600,13 @@ gtk_grid_view_measure_across (GtkWidget *widget,
 {
   GtkGridView *self = GTK_GRID_VIEW (widget);
   int xspacing;
-  int col_min, col_nat, header_min, header_nat;
 
   gtk_list_base_get_border_spacing (GTK_LIST_BASE (widget), &xspacing, NULL);
 
-  gtk_grid_view_measure_column_size (self, &col_min, &col_nat, &header_min, &header_nat);
+  gtk_grid_view_measure_column_size (self, minimum, natural);
 
-  *minimum = MAX ((col_min + xspacing) * self->min_columns - xspacing, header_min);
+  *minimum = (*minimum + xspacing) * self->min_columns - xspacing;
-  *natural = MAX ((col_nat + xspacing) * self->max_columns - xspacing, header_nat);
+  *natural = (*natural + xspacing) * self->max_columns - xspacing;
 }
 
 static guint
@@ -848,7 +642,7 @@ gtk_grid_view_measure_list (GtkWidget *widget,
   GtkScrollablePolicy scroll_policy;
   GtkListTile *tile;
   int height, row_height, child_min, child_nat, column_size, col_min, col_nat;
-  int xspacing, yspacing, header_min, header_nat;
+  int xspacing, yspacing;
   gboolean measured;
   GArray *heights;
   guint n_unknown, n_columns;
@@ -860,7 +654,7 @@ gtk_grid_view_measure_list (GtkWidget *widget,
   n_unknown = 0;
   height = 0;
 
-  gtk_grid_view_measure_column_size (self, &col_min, &col_nat, &header_min, &header_nat);
+  gtk_grid_view_measure_column_size (self, &col_min, &col_nat);
   for_size = MAX (for_size, col_min * (int) self->min_columns);
   n_columns = gtk_grid_view_compute_n_columns (self, for_size, xspacing, col_min, col_nat);
   column_size = (for_size + xspacing) / n_columns - xspacing;
@@ -876,7 +670,7 @@ gtk_grid_view_measure_list (GtkWidget *widget,
         {
           gtk_widget_measure (tile->widget,
                               gtk_list_base_get_orientation (GTK_LIST_BASE (self)),
-                              gtk_list_tile_is_header (tile) ? for_size : column_size,
+                              column_size,
                               &child_min, &child_nat, NULL, NULL);
           if (scroll_policy == GTK_SCROLL_MINIMUM)
             row_height = MAX (row_height, child_min);
@@ -885,10 +679,7 @@ gtk_grid_view_measure_list (GtkWidget *widget,
           measured = TRUE;
         }
 
-      if (gtk_list_tile_is_header (tile) || gtk_list_tile_is_footer (tile))
+      i += tile->n_items;
-        i = n_columns;
-      else
-        i += tile->n_items;
 
       if (i >= n_columns)
         {
@@ -945,48 +736,6 @@ gtk_grid_view_measure (GtkWidget      *widget,
     gtk_grid_view_measure_across (widget, for_size, minimum, natural);
 }
 
-void
-gtk_grid_view_split_tiles_by_columns (GtkListItemManager *items,
-                                      guint               n_columns)
-{
-  GtkListTile *tile;
-
-  for (tile = gtk_list_item_manager_get_first (items);
-       tile != NULL;
-       tile = gtk_rb_tree_node_get_next (tile))
-    {
-      if (tile->n_items > 1)
-        {
-          guint pos, col;
-          guint remaining;
-
-          pos = gtk_list_tile_get_position (items, tile);
-          col = gtk_grid_view_get_column_for_position (items, n_columns, pos);
-
-          if (col > 0)
-            {
-              /* Determine if the first row needs to be split off */
-              remaining = n_columns - col;
-              if (remaining > 0 && tile->n_items > remaining)
-                gtk_list_tile_split (items, tile, remaining);
-
-              continue;
-            }
-
-          pos += tile->n_items - 1;
-          col = gtk_grid_view_get_column_for_position (items, n_columns, pos);
-
-          if (col < n_columns - 1)
-            {
-              /* Determine if the last row needs to be split off */
-              remaining = n_columns - (col - 1);
-              if (remaining > 0 && col + 1 < tile->n_items)
-                tile = gtk_list_tile_split (items, tile, tile->n_items - (col + 1));
-            }
-        }
-    }
-}
-
 static void
 gtk_grid_view_size_allocate (GtkWidget *widget,
                              int        width,
@@ -997,7 +746,6 @@ gtk_grid_view_size_allocate (GtkWidget *widget,
   GtkListTile *tile, *start;
   GArray *heights;
   int min_row_height, unknown_row_height, row_height, col_min, col_nat;
-  int header_min, header_nat;
   GtkOrientation orientation;
   GtkScrollablePolicy scroll_policy;
   int y, xspacing, yspacing;
@@ -1019,7 +767,7 @@ gtk_grid_view_size_allocate (GtkWidget *widget,
     }
 
   /* step 1: determine width of the list */
-  gtk_grid_view_measure_column_size (self, &col_min, &col_nat, &header_min, &header_nat);
+  gtk_grid_view_measure_column_size (self, &col_min, &col_nat);
   self->n_columns = gtk_grid_view_compute_n_columns (self,
                                                      orientation == GTK_ORIENTATION_VERTICAL ? width : height,
                                                      xspacing,
@@ -1027,32 +775,28 @@ gtk_grid_view_size_allocate (GtkWidget *widget,
   self->column_width = ((orientation == GTK_ORIENTATION_VERTICAL ? width : height) + xspacing) / self->n_columns - xspacing;
   self->column_width = MAX (self->column_width, col_min);
 
-  /* step 2: split tiles as required */
+  /* step 2: determine height of known rows */
-  gtk_grid_view_split_tiles_by_columns (self->item_manager, self->n_columns);
-
-  /* step 3: determine height of known rows */
   heights = g_array_new (FALSE, FALSE, sizeof (int));
 
-  tile = gtk_list_item_manager_get_first (self->item_manager);
   while (tile != NULL)
     {
-      if (gtk_grid_view_is_multirow_tile (self->item_manager, self->n_columns, tile) ||
+      /* if it's a multirow tile, handle it here */
-          gtk_list_tile_is_header (tile))
+      if (tile->n_items > 1 && tile->n_items >= self->n_columns)
         {
-          gtk_list_tile_set_area_size (self->item_manager, tile, 0, 0);
+          if (tile->n_items % self->n_columns)
+            gtk_list_tile_split (self->item_manager, tile, tile->n_items / self->n_columns * self->n_columns);
           tile = gtk_rb_tree_node_get_next (tile);
           continue;
         }
 
+      /* Not a multirow tile */
+      i = 0;
       row_height = 0;
 
       for (i = 0, start = tile;
            i < self->n_columns && tile != NULL;
            tile = gtk_rb_tree_node_get_next (tile))
         {
-          g_assert (!gtk_list_tile_is_header (start));
-          gtk_list_tile_set_area_size (self->item_manager, tile, 0, 0);
-
           if (tile->widget)
             {
               int min, nat, size;
@@ -1065,49 +809,35 @@ gtk_grid_view_size_allocate (GtkWidget *widget,
               else
                 size = nat;
               size = MAX (size, min_row_height);
-              if (tile->type == GTK_LIST_TILE_ITEM)
+              g_array_append_val (heights, size);
-                g_array_append_val (heights, size);
               row_height = MAX (row_height, size);
             }
-          if (gtk_list_tile_is_footer (tile))
+          if (tile->n_items > self->n_columns - i)
-            i = self->n_columns;
+            gtk_list_tile_split (self->item_manager, tile, self->n_columns - i);
-          else
+          i += tile->n_items;
-            i += tile->n_items;
         }
-
       if (row_height > 0)
         {
           for (i = 0;
                start != tile;
                start = gtk_rb_tree_node_get_next (start))
             {
-              unsigned int n_columns;
-
-              g_assert (!gtk_list_tile_is_header (start));
-
-              if (gtk_list_tile_is_footer (start))
-                n_columns = self->n_columns - i;
-              else
-                n_columns = start->n_items;
-
               gtk_list_tile_set_area_size (self->item_manager,
                                            start,
-                                           column_end (self, xspacing, i + n_columns - 1)
+                                           column_end (self, xspacing, i + start->n_items - 1)
                                            - column_start (self, xspacing, i),
                                            row_height);
-
+              i += start->n_items;
-              i = (i + n_columns) % self->n_columns;
             }
+          g_assert (i <= self->n_columns);
         }
     }
 
-  /* step 4: determine height of rows with only unknown items */
+  /* step 3: determine height of rows with only unknown items */
   unknown_row_height = gtk_grid_view_get_unknown_row_size (self, heights);
   g_array_free (heights, TRUE);
 
-  g_assert (unknown_row_height > 0);
+  /* step 4: determine height for remaining rows and set each row's position */
-
-  /* step 5: determine height for remaining rows and set each row's position */
   y = 0;
   i = 0;
   for (tile = gtk_list_item_manager_get_first (self->item_manager);
@@ -1118,10 +848,10 @@ gtk_grid_view_size_allocate (GtkWidget *widget,
                                        tile,
                                        column_start (self, xspacing, i),
                                        y);
-
+      if (tile->n_items >= self->n_columns && tile->widget == NULL)
-      if (gtk_grid_view_is_multirow_tile (self->item_manager, self->n_columns, tile))
         {
           g_assert (i == 0);
+          g_assert (tile->n_items % self->n_columns == 0);
           gtk_list_tile_set_area_size (self->item_manager,
                                        tile,
                                        column_end (self, xspacing, self->n_columns - 1)
@@ -1129,59 +859,18 @@ gtk_grid_view_size_allocate (GtkWidget *widget,
                                        (unknown_row_height + yspacing) * (tile->n_items / self->n_columns) - yspacing);
           y += tile->area.height + yspacing;
         }
-      else if (gtk_list_tile_is_header (tile))
-        {
-          int size;
-
-          g_assert (i == 0);
-          if (tile->widget)
-            {
-              int min, nat;
-
-              gtk_widget_measure (tile->widget,
-                                  gtk_list_base_get_orientation (GTK_LIST_BASE (self)),
-                                  (self->column_width + xspacing) * self->n_columns,
-                                  &min, &nat, NULL, NULL);
-
-              if (scroll_policy == GTK_SCROLL_MINIMUM)
-                size = min;
-              else
-                size = nat;
-
-              size = MAX (size, min_row_height);
-            }
-          else if (gtk_list_item_manager_get_has_sections (self->item_manager))
-            size = unknown_row_height;
-          else
-            size = 0;
-
-          gtk_list_tile_set_area_size (self->item_manager,
-                                       tile,
-                                       column_end (self, xspacing, self->n_columns - 1)
-                                       - column_start (self, xspacing, 0),
-                                       size);
-
-          y += tile->area.height + yspacing;
-        }
       else
         {
-          unsigned int n_items = tile->n_items;
-
-          if (gtk_list_tile_is_footer (tile))
-            {
-              if (i == 0)
-                n_items = 0;
-              else
-                n_items = self->n_columns - i;
-            }
-
           if (tile->area.height == 0)
-            gtk_list_tile_set_area_size (self->item_manager,
+            {
-                                         tile,
+              /* this case is for the last row - it may not be a full row so it won't
-                                         column_end (self, xspacing, i + n_items - 1) - tile->area.x,
+               * be a multirow tile but it may have no widgets either */
-                                         unknown_row_height);
+              gtk_list_tile_set_area_size (self->item_manager,
-
+                                           tile,
-          i += n_items;
+                                           column_end (self, xspacing, i + tile->n_items - 1) - tile->area.x,
+                                           unknown_row_height);
+            }
+          i += tile->n_items;
         }
 
       if (i >= self->n_columns)
@@ -1191,8 +880,23 @@ gtk_grid_view_size_allocate (GtkWidget *widget,
           i = 0;
         }
     }
+  /* Add a filler tile for empty space in the bottom right */
+  if (i > 0)
+    {
+      GtkListTile *footer = gtk_list_item_manager_get_last (self->item_manager);
+      g_assert (gtk_list_tile_is_footer (footer));
+      tile = gtk_rb_tree_node_get_previous (footer);
+      gtk_list_tile_set_area_position (self->item_manager,
+                                       footer,
+                                       column_start (self, xspacing, i),
+                                       y);
+      gtk_list_tile_set_area_size (self->item_manager,
+                                   footer,
+                                   column_end (self, xspacing, self->n_columns - 1) - footer->area.x,
+                                   tile->area.height);
+    }
 
-  /* step 6: allocate the rest */
+  /* step 4: allocate the rest */
   gtk_list_base_allocate (GTK_LIST_BASE (self));
 }
 
@@ -1248,7 +952,6 @@ gtk_grid_view_dispose (GObject *object)
   self->item_manager = NULL;
 
   g_clear_object (&self->factory);
-  g_clear_object (&self->header_factory);
 
   G_OBJECT_CLASS (gtk_grid_view_parent_class)->dispose (object);
 }
@@ -1271,10 +974,6 @@ gtk_grid_view_get_property (GObject    *object,
       g_value_set_object (value, self->factory);
       break;
 
-    case PROP_HEADER_FACTORY:
-      g_value_set_object (value, self->header_factory);
-      break;
-
     case PROP_MAX_COLUMNS:
       g_value_set_uint (value, self->max_columns);
       break;
@@ -1319,10 +1018,6 @@ gtk_grid_view_set_property (GObject      *object,
       gtk_grid_view_set_factory (self, g_value_get_object (value));
       break;
 
-    case PROP_HEADER_FACTORY:
-      gtk_grid_view_set_header_factory (self, g_value_get_object (value));
-      break;
-
     case PROP_MAX_COLUMNS:
       gtk_grid_view_set_max_columns (self, g_value_get_uint (value));
       break;
@@ -1376,8 +1071,6 @@ gtk_grid_view_class_init (GtkGridViewClass *klass)
 
   list_base_class->split = gtk_grid_view_split;
   list_base_class->create_list_widget = gtk_grid_view_create_list_widget;
-  list_base_class->prepare_section = gtk_grid_view_prepare_section;
-  list_base_class->create_header_widget = gtk_grid_view_create_header_widget;
   list_base_class->get_allocation = gtk_grid_view_get_allocation;
   list_base_class->get_items_in_rect = gtk_grid_view_get_items_in_rect;
   list_base_class->get_position_from_allocation = gtk_grid_view_get_position_from_allocation;
@@ -1416,19 +1109,6 @@ gtk_grid_view_class_init (GtkGridViewClass *klass)
                          G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
 
 
-  /**
-   * GtkGridView:header-factory: (attributes org.gtk.Property.get=gtk_grid_view_get_header_factory org.gtk.Property.set=gtk_grid_view_set_header_factory)
-   *
-   * Factory for creating header widgets.
-   *
-   * Since: 4.12
-   */
-  properties[PROP_HEADER_FACTORY] =
-    g_param_spec_object ("header-factory", NULL, NULL,
-                         GTK_TYPE_LIST_ITEM_FACTORY,
-                         G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS);
-
-
   /**
    * GtkGridView:max-columns: (attributes org.gtk.Property.get=gtk_grid_view_get_max_columns org.gtk.Property.set=gtk_grid_view_set_max_columns)
    *
@@ -1662,69 +1342,6 @@ gtk_grid_view_set_factory (GtkGridView        *self,
   g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_FACTORY]);
 }
 
-/**
- * gtk_grid_view_get_header_factory: (attributes org.gtk.Method.get_property=header-factory)
- * @self: a `GtkGridView`
- *
- * Gets the factory that's currently used to populate section headers.
- *
- * Returns: (nullable) (transfer none): The factory in use
- *
- * Since: 4.12
- */
-GtkListItemFactory *
-gtk_grid_view_get_header_factory (GtkGridView *self)
-{
-  g_return_val_if_fail (GTK_IS_GRID_VIEW (self), NULL);
-
-  return self->header_factory;
-}
-
-/**
- * gtk_grid_view_set_header_factory: (attributes org.gtk.Method.set_property=header-factory)
- * @self: a `GtkGridView`
- * @factory: (nullable) (transfer none): the factory to use
- *
- * Sets the `GtkListItemFactory` to use for populating the
- * [class@Gtk.ListHeader] objects used in section headers.
- *
- * If this factory is set to %NULL, the list will not show section headers.
- *
- * Since: 4.12
- */
-void
-gtk_grid_view_set_header_factory (GtkGridView        *self,
-                                  GtkListItemFactory *factory)
-{
-  gboolean had_sections;
-
-  g_return_if_fail (GTK_IS_GRID_VIEW (self));
-  g_return_if_fail (factory == NULL || GTK_IS_LIST_ITEM_FACTORY (factory));
-
-  had_sections = gtk_list_item_manager_get_has_sections (self->item_manager);
-
-  if (!g_set_object (&self->header_factory, factory))
-    return;
-
-  gtk_list_item_manager_set_has_sections (self->item_manager, factory != NULL);
-
-  if (!gtk_grid_view_is_inert (self) &&
-      had_sections && gtk_list_item_manager_get_has_sections (self->item_manager))
-    {
-      GtkListTile *tile;
-
-      for (tile = gtk_list_item_manager_get_first (self->item_manager);
-           tile != NULL;
-           tile = gtk_rb_tree_node_get_next (tile))
-        {
-          if (tile->widget && tile->type == GTK_LIST_TILE_HEADER)
-            gtk_list_header_widget_set_factory (GTK_LIST_HEADER_WIDGET (tile->widget), factory);
-        }
-    }
-
-  g_object_notify_by_pspec (G_OBJECT (self), properties[PROP_HEADER_FACTORY]);
-}
-
 /**
  * gtk_grid_view_get_max_columns: (attributes org.gtk.Method.get_property=max-columns)
  * @self: a `GtkGridView`

gtk/gtkgridview.h

@@ -56,14 +56,6 @@ void            gtk_grid_view_set_factory                       (GtkGridView
 GDK_AVAILABLE_IN_ALL
 GtkListItemFactory *
                 gtk_grid_view_get_factory                       (GtkGridView            *self);
-
-GDK_AVAILABLE_IN_4_12
-void            gtk_grid_view_set_header_factory                (GtkGridView            *self,
-                                                                 GtkListItemFactory     *factory);
-GDK_AVAILABLE_IN_4_12
-GtkListItemFactory *
-                gtk_grid_view_get_header_factory                (GtkGridView            *self);
-
 GDK_AVAILABLE_IN_ALL
 guint           gtk_grid_view_get_min_columns                   (GtkGridView            *self);
 GDK_AVAILABLE_IN_ALL

gtk/gtkgridviewprivate.h

@@ -1,45 +0,0 @@
-/*
- * Copyright © 2023 Red Hat, Inc.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this library. If not, see <http://www.gnu.org/licenses/>.
- */
-
-
-#pragma once
-
-#include "gtk/gtktypes.h"
-#include "gtk/gtkenums.h"
-#include "gtk/gtkgridview.h"
-#include "gtk/gtklistitemmanagerprivate.h"
-
-G_BEGIN_DECLS
-
-void         gtk_grid_view_get_section_for_position (GtkListItemManager *items,
-                                                     unsigned int        position,
-                                                     unsigned int       *start,
-                                                     unsigned int       *end);
-
-unsigned int gtk_grid_view_get_column_for_position (GtkListItemManager *items,
-                                                    unsigned int        n_columns,
-                                                    unsigned int        position);
-
-gboolean     gtk_grid_view_is_multirow_tile        (GtkListItemManager *items,
-                                                    unsigned int        n_columns,
-                                                    GtkListTile        *tile);
-
-void         gtk_grid_view_split_tiles_by_columns  (GtkListItemManager *items,
-                                                    guint               n_columns);
-
-G_END_DECLS
-

gtk/gtklistitemmanager.c

@@ -1004,6 +1004,8 @@ gtk_list_item_manager_merge_list_items (GtkListItemManager *self,
  * It is not valid for either tile to have 0 items after
  * the split.
  *
+ * This function does not update the tiles' areas.
+ *
  * Returns: The new tile
  **/
 GtkListTile *
@@ -1037,10 +1039,6 @@ gtk_list_tile_split (GtkListItemManager *self,
  *
  * Note that this only looks forward, but never backward.
  *
- * A special case here are filler tiles. They only get
- * collected, when they are explicitly passed in, but never
- * otherwise.
- *
  * Returns: The next tile or NULL if everything was gc'ed
  **/
 static GtkListTile *
@@ -1093,6 +1091,15 @@ gtk_list_tile_gc (GtkListItemManager *self,
   return tile;
 }
 
+/*
+ * gtk_list_item_manager_gc_tiles:
+ * @self: the listitemmanager
+ *
+ * Removes all tiles of type GTK_LIST_TILE_REMOVED
+ * and merges item tiles as much as possible.
+ *
+ * This function does not update the tiles' areas.
+ */
 void
 gtk_list_item_manager_gc_tiles (GtkListItemManager *self)
 {

gtk/gtkmenubutton.c

@@ -1094,6 +1094,7 @@ gtk_menu_button_get_icon_name (GtkMenuButton *menu_button)
  * gtk_menu_button_set_always_show_arrow: (attributes org.gtk.Method.set_property=always-show-arrow)
  * @menu_button: a `GtkMenuButton`
  * @always_show_arrow: whether to show a dropdown arrow even when using an icon
+ * or a custom child
  *
  * Sets whether to show a dropdown arrow even when using an icon or a custom
  * child.
@@ -1122,9 +1123,11 @@ gtk_menu_button_set_always_show_arrow (GtkMenuButton *menu_button,
  * gtk_menu_button_get_always_show_arrow: (attributes org.gtk.Method.get_property=always-show-arrow)
  * @menu_button: a `GtkMenuButton`
  *
- * Gets whether to show a dropdown arrow even when using an icon.
+ * Gets whether to show a dropdown arrow even when using an icon or a custom
+ * child.
  *
- * Returns: whether to show a dropdown arrow even when using an icon
+ * Returns: whether to show a dropdown arrow even when using an icon or a custom
+ * child.
  *
  * Since: 4.4
  */

testsuite/css/parser/font-family.css

@@ -25,3 +25,7 @@ f {
 g {
   font-family: Macaroni al dente, Tomato sauce;
 }
+
+h {
+  font-family: 楷体;
+}

testsuite/css/parser/font-family.ref.css

@@ -25,3 +25,7 @@ f {
 g {
   font-family: "Macaroni al dente", "Tomato sauce";
 }
+
+h {
+  font-family: "楷体";
+}

testsuite/gtk/listitemmanager.c

@@ -20,7 +20,6 @@
 #include <gtk/gtk.h>
 #include "gtk/gtklistitemmanagerprivate.h"
 #include "gtk/gtklistbaseprivate.h"
-#include "gtk/gtkgridviewprivate.h"
 
 static GListModel *
 create_source_model (guint min_size, guint max_size)
@@ -375,66 +374,7 @@ print_changes_cb (GListModel *model,
 }
 
 static void
-check_tile_invariants_for_columns (GtkListItemManager *items,
+test_exhaustive (void)
-                                   unsigned int        n_columns)
-{
-  GtkListTile *tile;
-
-  for (tile = gtk_list_item_manager_get_first (items);
-       tile != NULL;
-       tile = gtk_rb_tree_node_get_next (tile))
-    {
-      g_assert (tile->type != GTK_LIST_TILE_REMOVED);
-      if (tile->n_items > 1)
-        {
-          unsigned int pos, col, col2, end;
-
-          pos = gtk_list_tile_get_position (items, tile);
-          col = gtk_grid_view_get_column_for_position (items, n_columns, pos);
-          col2 = gtk_grid_view_get_column_for_position (items, n_columns, pos + tile->n_items - 1);
-          gtk_grid_view_get_section_for_position (items, pos + tile->n_items - 1, NULL, &end);
-
-          if (gtk_grid_view_is_multirow_tile (items, n_columns, tile))
-            {
-              g_assert_true (col == 0);
-              g_assert_true (col2 == n_columns - 1 || pos + tile->n_items == end);
-            }
-          else
-            {
-              g_assert_true (col2 == col + tile->n_items - 1);
-              g_assert_true (col2 <= n_columns);
-            }
-        }
-    }
-}
-
-static void
-check_grid_view (GtkListItemManager *items)
-{
-  for (unsigned int n_columns = 1; n_columns < 10; n_columns++)
-    {
-      if (g_test_verbose ())
-        g_test_message ("GC");
-
-      gtk_list_item_manager_gc_tiles (items);
-
-      if (g_test_verbose ())
-        print_list_item_manager_tiles (items);
-
-      if (g_test_verbose ())
-        g_test_message ("grid split %u columns", n_columns);
-
-      gtk_grid_view_split_tiles_by_columns (items, n_columns);
-
-      if (g_test_verbose ())
-        print_list_item_manager_tiles (items);
-
-      check_tile_invariants_for_columns (items, n_columns);
-    }
-}
-
-static void
-test_exhaustive (gboolean grid)
 {
   GtkListItemTracker *trackers[N_TRACKERS];
   GListStore *store;
@@ -472,14 +412,9 @@ test_exhaustive (gboolean grid)
       switch (g_test_rand_int_range (0, 6))
       {
         case 0:
-          if (grid)
+          if (g_test_verbose ())
-            check_grid_view (items);
+            g_test_message ("GC and checking");
-          else
+          check_list_item_manager (items, trackers, N_TRACKERS);
-            {
-              if (g_test_verbose ())
-                g_test_message ("GC and checking");
-              check_list_item_manager (items, trackers, N_TRACKERS);
-            }
           break;
 
         case 1:
@@ -549,10 +484,7 @@ test_exhaustive (gboolean grid)
         }
     }
 
-  if (grid)
+  check_list_item_manager (items, trackers, N_TRACKERS);
-    check_grid_view (items);
-  else
-    check_list_item_manager (items, trackers, N_TRACKERS);
 
   for (i = 0; i < N_TRACKERS; i++)
     gtk_list_item_tracker_free (items, trackers[i]);
@@ -560,18 +492,6 @@ test_exhaustive (gboolean grid)
   gtk_window_destroy (GTK_WINDOW (widget));
 }
 
-static void
-test_exhaustive_list (void)
-{
-  test_exhaustive (FALSE);
-}
-
-static void
-test_exhaustive_grid (void)
-{
-  test_exhaustive (TRUE);
-}
-
 int
 main (int argc, char *argv[])
 {
@@ -579,8 +499,7 @@ main (int argc, char *argv[])
 
   g_test_add_func ("/listitemmanager/create", test_create);
   g_test_add_func ("/listitemmanager/create_with_items", test_create_with_items);
-  g_test_add_func ("/listitemmanager/exhaustive", test_exhaustive_list);
+  g_test_add_func ("/listitemmanager/exhaustive", test_exhaustive);
-  g_test_add_func ("/gridview/split", test_exhaustive_grid);
 
   return g_test_run ();
 }