From 13d49751f4f656c4ea12f3ed4cde2c404cf557ae Mon Sep 17 00:00:00 2001 From: Jeff Epler Date: Fri, 26 Sep 2025 15:30:09 -0500 Subject: [PATCH] tools/ci.sh: Re-add IGNORE_ERRORS to ci_code_size_build. It was removed (possibly inadvertently) in 4c55b0879b38b373b44e84552d6754b7842b5b72 Signed-off-by: Jeff Epler --- tools/ci.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/ci.sh b/tools/ci.sh index fe71c30c54..80749d4b71 100755 --- a/tools/ci.sh +++ b/tools/ci.sh @@ -110,6 +110,7 @@ function ci_code_size_build { COMMIT=$1 OUTFILE=$2 + IGNORE_ERRORS=$3 echo "Building ${COMMIT}..." git checkout --detach $COMMIT @@ -118,14 +119,15 @@ function ci_code_size_build { tools/metrics.py clean "$PORTS_TO_CHECK" # Allow errors from tools/metrics.py to propagate out of the pipe below. set -o pipefail - tools/metrics.py build "$PORTS_TO_CHECK" | tee $OUTFILE + tools/metrics.py build "$PORTS_TO_CHECK" | tee $OUTFILE || $IGNORE_ERRORS + return $? } # build reference, save to size0 # ignore any errors with this build, in case master is failing - code_size_build_step $REFERENCE ~/size0 + code_size_build_step $REFERENCE ~/size0 true # build PR/branch, save to size1 - code_size_build_step $COMPARISON ~/size1 + code_size_build_step $COMPARISON ~/size1 false ) }