2413 Commits

Author	SHA1	Message	Date
Damien George	7746785035	tests/run-tests.py: Wait for soft reset if a target skips a test. ... Commit 69c25ea865 made raising `SystemExit` do a soft reset (on bare-metal targets). This means that any test which is skipped by a target (by raising `SystemExit`) will trigger a soft reset on that target, and then it must execute its startup code, such as `boot.py`. If the timing is right, this startup code can be unintentionally interrupted by the test runner when preparing the next test, because the test runner enters the raw REPL again via a Ctrl-C Ctrl-A ctrl-D sequence (in `Pyboard.enter_raw_repl()`). When this happens (`boot.py` is interrupted) the target may not be set up correctly, and it may (in the case of stm32 boards) flash LEDs and take extra time, slowing down the test run. Fix this by explicitly waiting for the target to finish its soft reset when it skips a test. Signed-off-by: Damien George <damien@micropython.org>	2024-10-15 11:23:07 +11:00
Angus Gratton	05ac69329d	esp32: Fix hang in taskYIELD() on riscv CPUs when IRQs disabled. ... Regression introduced in 337742f. The hang occurs because the esp32 port was calling "from ISR" port-layer functions to set/clear the interrupt mask. FreeRTOS kernel therefore doesn't know the CPU is in a critical section. In taskYIELD() the riscv port layer blocks after yielding until it knows the yield has happened, and would block indefinitely if IRQs are disabled (until INT WDT triggers). Moving to the "public" portENTER_CRITICAL/portEXIT_CRITICAL API means that FreeRTOS knows we're in a critical section and can react accordingly. Adds a regression test for this case (should be safe to run on all ports). On single core CPUs, this should result in almost exactly the same behaviour apart from fixing this case. On dual core CPUs, we now have cross-CPU mutual exclusion for atomic sections. This also shouldn't change anything, mostly because all the code which enters an atomic section runs on the same CPU. If it does change something, it will be to fix a thread safety bug. There is some risk that this change triggers a FreeRTOS crash where there is a call to a blocking FreeRTOS API with interrupts disabled. Previously this code might have worked, but was probably thread unsafe and would have hung in some circumstances. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-10-10 10:59:51 +11:00
Damien George	197becbdcc	tests: Tweak machine SPI and UART tests to work with esp32c6. ... Signed-off-by: Damien George <damien@micropython.org>	2024-10-09 23:34:27 +11:00
Andrew Leech	c2eebe0609	tests/README: Update instructions for key/cert pair usage on device. ... Signed-off-by: Andrew Leech <andrew@alelec.net>	2024-10-09 14:37:59 +11:00
stijn	338df1ae35	py/objtype: Allow passing keyword arguments to native base __init__. ... Allowing passing keyword arguments to a native base's __init__, i.e. `make_new` in the C code. Previously only positional arguments were allowed. The main trade-off in this commit is that every call to the native base's `make_new` is now going to be preceded by a call to `mp_map_init_fixed_table` even though most of what that does is unused and instead it merely serves as a way to pass the number of keyword arguments. Fixes issue #15465. Signed-off-by: stijn <stijn@ignitron.net>	2024-10-07 11:37:52 +11:00
Alessandro Gatti	43b05afdf5	py/mpz: Skip separators when running out of digits to print. ... This commit fixes the addition of a stray separator before the number when printing an MPZ-backed integer and the first group is three digits long. This fixes #8984. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>	2024-09-26 23:39:06 +10:00
Damien George	5b22bde044	py/persistentcode: Explicitly track native BSS/rodata when needed. ... Signed-off-by: Damien George <damien@micropython.org>	2024-09-26 22:15:28 +10:00
Angus Gratton	f4ab9d9247	extmod/vfs_blockdev: Implement common helper for read and write. ... - Code size saving as all of these functions are very similar. - Resolves the "TODO" of the plain read and write functions not propagating errors. An error in the underlying block device now causes VFatFs to return EIO, for example. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-09-26 22:08:48 +10:00
Angus Gratton	4f6d4b2b49	extmod/vfs_blockdev: Check block device function positive results. ... A positive result here can result in eventual memory corruption as littlefs expects the result of a cache read/write function to be 0 or a negative integer for an error. Closes #13046 This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-09-26 22:08:48 +10:00
Andrew Leech	7e14680a83	py/objringio: Add micropython.RingIO() interface for general use. ... This commit adds a new `RingIO` type which exposes the internal ring-buffer code for general use in Python programs. It has the stream interface making it similar to `StringIO` and `BytesIO`, except `RingIO` has a fixed buffer size and is automatically safe when reads and writes are in different threads or an IRQ. This new type is enabled at the "extra features" ROM level. Signed-off-by: Andrew Leech <andrew.leech@planetinnovation.com.au>	2024-09-19 18:00:44 +10:00
Michael Sawyer	230e521515	tests/ports/unix: Update and extend the modffi integer tests. ... Added the "long" modffi tests. The tests could not be added to the existing ffi_types test because two .exp files were required for the 32-bit and 64-bit results. Code common to both the ffi_types and type "long" tests was factored into ffi_int_base. ffi_types was renamed to ffi_int_types to group the related tests under the "ffi_int" prefix. Signed-off-by: Michael Sawyer <mjfsawyer@gmail.com>	2024-09-19 15:00:17 +10:00
Damien George	1be38e8077	tests/run-tests.py: Remove --write-exp and --list-tests options. ... Removing the now-unused (see previous commit for details) `--write-exp` and `--list-tests` options helps to simplify the rather complex logic in `run-tests.py`. Signed-off-by: Damien George <damien@micropython.org>	2024-09-19 13:36:04 +10:00
Angus Gratton	5d8878b582	shared/tinyusb: Only run TinyUSB on the main thread if GIL is disabled. ... If GIL is disabled then there's threat of a race condition if some other code specifically requests USB processing (i.e. to unblock stdio), while a scheduled TinyUSB callback is already running on another thread. Relies on the change in the parent commit, where scheduler is restricted to main thread if GIL is disabled. Fixes #15390 - "TinyUSB callback can't recurse" exceptions on rp2 when using _thread module and USB serial I/O. Adds a unit test for stdin functioning correctly in threads (fails on rp2 port without this fix). This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-09-19 13:17:01 +10:00
Damien George	74d6dba294	tests/run-tests.py: Add a zephyr test target. ... So that certain tests can be skipped when running on this target. These thread tests do not pass because the zephyr port cannot create more than 4 threads at once. Signed-off-by: Damien George <damien@micropython.org>	2024-09-06 20:47:19 +10:00
danicampora	935fcd1329	tests/thread: Adapt stress_aes.py to run on zephyr. ... Signed-off-by: danicampora <danicampora@gmail.com>	2024-09-06 20:42:57 +10:00
robert-hh	e23fdb1f77	tests/extmod/machine_uart_irq_txidle.py: Simplify the test script. ... Now that no minimal delay time is required for SAMD devices. Signed-off-by: robert-hh <robert@hammelrath.com>	2024-09-06 17:43:49 +10:00
timdechant	455415b1e1	shared/runtime/sys_stdio_mphal: Fix printed type for stdio streams. ... The printed type for stdio streams indicates "FileIO", which is a binary IO stream. Stdio is not binary by design, and its printed type should indicate a text stream. "TextIOWrapper" suits that purpose, and is used by VfsPosix files. Signed-off-by: timdechant <timdechant.git@gmail.com>	2024-09-06 17:00:35 +10:00
Damien George	659113825d	qemu: Rename qemu-arm port to qemu. ... Because this port now supports multiple architectures. Signed-off-by: Damien George <damien@micropython.org>	2024-09-06 11:08:39 +10:00
Damien George	3ea1ce63da	all: Remove remaining qemu-riscv references. ... Signed-off-by: Damien George <damien@micropython.org>	2024-09-06 11:08:22 +10:00
Damien George	6be1dbc784	tests/run-tests.py: Automatically detect native arch and mpy-cross flag. ... Now that some ports support multiple architectures (eg esp32 has both Xtensa and RISC-V CPUs) it's no longer possible to set mpy-cross flags based on the target, eg `./run-tests.py --target esp32`. Instead this commit makes it so the `-march=xxx` argument to mpy-cross is detected automatically via evaluation of `sys.implementation._mpy`. Signed-off-by: Damien George <damien@micropython.org>	2024-09-04 16:34:01 +10:00
Damien George	838c490eb4	tests/net_inet: Update micropython.org certificate for SSL tests. ... The Let's Encrypt root certificate has changed so needs updating in this test. Signed-off-by: Damien George <damien@micropython.org>	2024-09-04 16:28:39 +10:00
Amirreza Hamzavi	1897fe6227	tests/basics: Add tests for optional args to int.to_bytes/from_bytes. ... Signed-off-by: Amirreza Hamzavi <amirrezahamzavi2000@gmail.com>	2024-09-02 14:15:49 +10:00
Damien George	09d070aa55	tests/extmod_hardware: Add tests for machine.UART.IRQ_RX/RXIDLE/BREAK. ... These all require hardware connections, so live in a different directory. Except for the IRQ_BREAK test of ESP32 devices a single UART with loopback is sufficient. General: SAMD21: Due to the limited flash size only SAMD21 devices with external flash support uart.irq(). IRQ_BREAK: ESP32 needs different UART devices for creating and sensing a break. Lacking a second UART the test is skipped for ESP32S2 and ESP32C3. RP2 does not pass the test reliable at 115200 baud, reason to be found. Thus the upper limit is set to 57600 Baud. Coverage: esp32 pass when different UART devices are used. rp2 pass up to 57600 baud IRQ_RX: SAMD21: Being a slow device it needs data to be sent byte-by-byte at 9600 baud, since the IRQ callback is scheduled delayed and then the flags do not match any more. The data matches since it is queued in the FIFO resp. ringbuffer. CC3200: The test cannot be performed since no calls are accepted in the IRQ handler like u.read(). Skipped. Coverage: cc3200 fail due to major differences in the implementation. esp32 pass nrf pass renesas-ra pass samd pass see the notes. stm32 pass IRQ_RXIDLE: STM32: With PyBoard the IRQ is called several times, but only once with the flag IRQ_RXIDLE set. Coverage: esp32 pass mimxrt pass renesas-ra pass rp2 pass samd pass for both SAMD21 and SAMD51 stm32 fail. see notes. Signed-off-by: Damien George <damien@micropython.org> Signed-off-by: robert-hh <robert@hammelrath.com>	2024-08-29 16:48:09 +10:00
Damien George	b8513e6137	tests/extmod: Add test for machine.UART.IRQ_TXIDLE. ... The test checks whether the message created by the IRQ handler appears about at the end of the data sent by UART. Supported MCUs resp. boards: - RP2040 - Teensy 4.x - Adafruit ItsyBitsy M0 - Adafruit ItsyBitsy M4 - NRF52 (Arduino Nano Connect 33 BLE) Signed-off-by: Damien George <damien@micropython.org>	2024-08-29 16:48:09 +10:00
Damien George	d9a0fdda9a	qemu-arm: Rework to provide a REPL and run tests via a pty serial port. ... Currently, the qemu-arm (and qemu-riscv) port has two build modes: - a simple test that executes a Python string; and - a full test that uses tinytest to embed all tests within the firmware, then executes that and captures the output. This is very different to all the other ports. A difficulty with using tinytest is that with the large number of tests the firmware overflows its virtual flash size. It's also hard to run tests via .mpy files and with the native emitter. Being different to the other ports also means an extra burden on maintenance. This commit reworks the qemu-arm port so that it has a single build target that creates a standard firmware which has a REPL. When run under qemu-system-arm, the REPL acts like any other bare-metal port, complete with soft reset (use machine.reset() to turn it off and exit qemu-system-arm). This approach gives many benefits: - allows playing with a REPL without hardware; - allows running the test suite as it would on a bare-metal board, by making qemu-system-arm redirect the UART serial of the virtual device to a /dev/pts/xx file, and then running run-tests.py against that serial device; - skipping tests is now done via the logic in `run-tests.py` and no longer needs multiple places to define which tests to skip (`tools/tinytest-codegen.py`, `ports/qemu-arm/tests_profile.txt` and also `tests/run-tests.py`); - allows testing/using mpremote with the qemu-arm port. Eventually the qemu-riscv port would have a similar change. Prior to this commit the test results were: 743 tests ok. (121 skipped) With this commit the test results are: 753 tests performed (22673 individual testcases) 753 tests passed 138 tests skipped More tests are skipped because more are included in the run. But overall more tests pass. Signed-off-by: Damien George <damien@micropython.org>	2024-08-28 11:52:08 +10:00
Damien George	86aa61918a	tests/run-tests.py: Skip additional tests when slice unavailable. ... Both of these tests require slice to be enabled. Signed-off-by: Damien George <damien@micropython.org>	2024-08-28 11:23:11 +10:00
Glenn Moloney	6367099f83	py/objstr: Skip whitespace in bytes.fromhex(). ... Skip whitespace characters between pairs of hex numbers. This makes `bytes.fromhex()` compatible with cpython. Includes simple test in `tests/basic/builtin_str_hex.py`. Signed-off-by: Glenn Moloney <glenn.moloney@gmail.com>	2024-08-19 14:18:34 +10:00
Angus Gratton	fb4ae1eeec	test/extmod: Fix machine_spi_rate test on ESP32-C3. ... Update to the test added in 1e98c4cb75, changes the SPI pins for ESP32-C3 (IO 18 and 19 are the native USB pins). Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-08-14 15:03:27 +10:00
Angus Gratton	a6fa85d8f9	unix: Switch stack limit check to new cstack API. ... Necessary to pass CI when testing the V2 preview APIs. Also adds an extra coverage test for the legacy stackctrl API, to maintain coverage and check for any regression. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-08-14 12:57:27 +10:00
Angus Gratton	80616aee71	tests/run-tests.py: Enable stress tests on esp32 port. ... Now passing on ESP32-S3 and ESP32-C3. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-08-14 12:56:56 +10:00
Peter Züger	1473ed4c64	tests/extmod/ssl_keycert.py: Add test for PKCS8 formatted DER key. ... Signed-off-by: Peter Züger <zueger.peter@icloud.com>	2024-08-13 17:32:32 +10:00
Angus Gratton	1e98c4cb75	tests/extmod: Add machine_spi_rate test. ... Based on machine_i2s_rate, allows testing basic SPI functionality and timings. Implemented and confirmed working for rp2, esp32, and pyboard. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-08-07 15:07:13 +10:00
Damien George	a4b3825bd4	tests/extmod: Rename machine_timer exp file to machine_soft_timer. ... This was missed in 9ba04cc756 Signed-off-by: Damien George <damien@micropython.org>	2024-08-07 15:02:52 +10:00
Angus Gratton	6d05424754	tests/extmod: Add esp32 support to the machine_i2s_rate test. ... This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-08-02 10:31:19 +10:00
Angus Gratton	9ba04cc756	tests/extmod: Skip soft machine.Timer test on esp32 port. ... Also rename the test to reflect that it's a soft timer test. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-08-02 10:27:53 +10:00
Damien George	e1fe62f4fc	tests/multi_net: Fix skipping of SSLContext tests when .der don't exist. ... The `sslcontext_server_client_ciphers.py` test was using stat to test for the .der files after it already tried to open them for reading. That is now fixed. And `sslcontext_server_client.py` is adjusted to use the same pattern for skipping the test. Signed-off-by: Damien George <damien@micropython.org>	2024-07-25 18:14:52 +10:00
stijn	1f907a2f5c	tests/run-tests.py: Make Windows test skipping more granular. ... Signed-off-by: stijn <stijn@ignitron.net>	2024-07-25 16:24:04 +10:00
stijn	a0c7bf12d2	github/workflows: Improve MSYS2-based CI builds. ... Install the mingw variant of Python since it behaves more like a 'real' Windows CPython than the msys2 variant: os.name == 'nt', not 'posix'. Note that os.sep is still '/' though so we don't actually need to skip the import_file test. This way one single Python version can be used both for running run-tests.py and getting the expected test output. Signed-off-by: stijn <stijn@ignitron.net>	2024-07-25 16:22:21 +10:00
Damien George	233f5ce661	py/runtime: Fix self arg passed to classmethod when accessed via super. ... Thanks to @AJMansfield for the original test case. Signed-off-by: Damien George <damien@micropython.org>	2024-07-25 13:07:42 +10:00
stijn	093d0c0a17	py/objtype: Validate super() arguments. ... This fixes various null dereferencing and out-of-bounds access because super_attr assumes the held obj is effectively an object of the held type, which is now verified. Fixes issue #12830. Signed-off-by: stijn <stijn@ignitron.net>	2024-07-25 12:27:33 +10:00
David Lechner	d1bf0eeb0f	tests/cpydiff: Add diff for overriding __init__. ... This adds a CPython diff that explains why calling `super().__init__()` is required in MicroPython when subclassing a native type (because `__new__` and `__init__` are not separate functions). Signed-off-by: David Lechner <david@pybricks.com>	2024-07-25 12:01:43 +10:00
Laurens Valk	9ca668f881	py/objtype: Avoid crash on calling members of uninitialized native type. ... When subclassing a native type, calling native members in `__init__` before `super().__init__()` has been called could cause a crash. In this situation, `self` in `mp_convert_member_lookup` is the `native_base_init_wrapper_obj`. The check added in this commit ensures that an `AttributeError` is raised before this happens, which is consistent with other failed lookups. Also fix a typo in a related comment. Signed-off-by: Laurens Valk <laurens@pybricks.com>	2024-07-25 12:01:43 +10:00
Laurens Valk	19b1333cb1	examples/usercmodule/cexample: Add more advanced native class. ... This adds a separate `AdvancedTimer` class that demonstrates a few more advanced concepts usch as custom handlers for printing and attributes. Signed-off-by: Laurens Valk <laurens@pybricks.com>	2024-07-25 11:57:13 +10:00
Angus Gratton	ba98533454	rp2: Stop machine.idle() blocking indefinitely. ... Updates rp2 port to always resume from idle within 1ms max. When rp2 port went tickless the behaviour of machine.idle() changed as there is no longer a tick interrupt to wake it up every millisecond. On a quiet system it would now block indefinitely. No other port does this. See parent commit for justification of why this change is useful. Also adds a test case that fails without this change. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-07-23 16:46:27 +10:00
Angus Gratton	46c3df0229	tests/run-tests.py: Enable thread tests on esp32. ... Before the fix in parent commit, some of these tests hung indefinitely. After, they seem to consistently pass. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-07-23 12:34:14 +10:00
Angus Gratton	337742f6c7	esp32/mpthreadport: Fix uneven GIL allocation between Python threads. ... Explicitly yield each time a thread mutex is unlocked. Key to understanding this bug is that Python threads run at equal RTOS priority, and although ESP-IDF FreeRTOS (and I think vanilla FreeRTOS) scheduler will round-robin equal priority tasks in the ready state it does not make a similar guarantee for tasks moving between ready and waiting. The pathological case of this bug is when one Python thread task is busy (i.e. never blocks) it will hog the CPU more than expected, sometimes for an unbounded amount of time. This happens even though it periodically unlocks the GIL to allow another task to run. Assume T1 is busy and T2 is blocked waiting for the GIL. T1 is executing and hits a condition to yield execution: 1. T1 calls MP_THREAD_GIL_EXIT 2. FreeRTOS sees T2 is waiting for the GIL and moves it to the Ready list (but does not preempt, as T2 is same priority, so T1 keeps running). 3. T1 immediately calls MP_THREAD_GIL_ENTER and re-takes the GIL. 4. Pre-emptive context switch happens, T2 wakes up, sees GIL is not available, and goes on the waiting list for the GIL again. To break this cycle step 4 must happen before step 3, but this may be a very narrow window of time so it may not happen regularly - and quantisation of the timing of the tick interrupt to trigger a context switch may mean it never happens. Yielding at the end of step 2 maximises the chance for another task to run. Adds a test that fails on esp32 before this fix and passes afterwards. Fixes issue #15423. This work was funded through GitHub Sponsors. Signed-off-by: Angus Gratton <angus@redyak.com.au>	2024-07-23 12:33:19 +10:00
stijn	444d7bacbe	extmod/moductypes: Validate the descriptor tuple. ... Fixes various null dereferencing, out-of-bounds memory accesses and `assert(0)` failures in the case of an invalid `uctypes` descriptor. By design `uctypes` can crash because it accesses arbitrary memory, but at least describing the descriptor layout should be forced to be correct and not crash. Fixes issue #12702. Signed-off-by: stijn <stijn@ignitron.net>	2024-07-22 14:40:45 +10:00
Michael Vornovitsky	6db91dfefb	extmod/modbtree: Add checks for already-closed database. ... Fixes use-after-free when accessing the database after it is closed with `btree_close`. `btree_close` always succeeds when called with an already-closed database. The new test checks that operations that access the underlying database (get, set, flush, seq) fail with a `ValueError` when the btree is already closed. It also checks that closing and printing the btree succeed when the btree is already closed. Fixes issue #12543. Signed-off-by: Michael Vornovitsky <michaelvornovitskiy@outlook.com>	2024-07-22 10:42:29 +10:00
Damien George	847ee20d9b	tests/multi_bluetooth/perf_gatt_notify.py: Reduce connection interval. ... To test that the notification ping-pong can be low latency. Signed-off-by: Damien George <damien@micropython.org>	2024-07-19 22:28:31 +10:00
Damien George	77bd8fe5b8	webassembly: Reuse PyProxy objects when they are the same Python object. ... This commit makes it so that PyProxy objects are reused (on the JavaScript side) when they correspond to an existing Python object that is the same object. For example, proxying the same Python function to JavaScript, the same PyProxy instance is now used. This means that if `foo` is a Python function then accessing it on the JavaScript side such as `api.globals().get("foo")` has the property that: api.globals().get("foo") === api.globals().get("foo") Prior to this commit the above was not true because new PyProxy instances were created each time `foo` was accessed. Signed-off-by: Damien George <damien@micropython.org>	2024-07-19 11:55:24 +10:00