From f990fea78cf6323c5cf4d012d8dc31dd7847e2e7 Mon Sep 17 00:00:00 2001 From: Talley Lambert Date: Sat, 20 May 2023 15:53:45 -0400 Subject: [PATCH] test: add qtbot to test to fix windows segfault (#165) * test: fix windows test * test on windows * try ubuntu * remove ubuntu --- .github/workflows/test_and_deploy.yml | 6 ++++++ tests/test_sliders/test_labeled_slider.py | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_and_deploy.yml b/.github/workflows/test_and_deploy.yml index 37d7e7a..8af5e5f 100644 --- a/.github/workflows/test_and_deploy.yml +++ b/.github/workflows/test_and_deploy.yml @@ -36,6 +36,12 @@ jobs: - python-version: "3.11" platform: macos-latest backend: pyside6 + - python-version: "3.10" + platform: windows-latest + backend: pyside6 + - python-version: "3.11" + platform: windows-latest + backend: pyside6 # python 3.7 - python-version: 3.7 diff --git a/tests/test_sliders/test_labeled_slider.py b/tests/test_sliders/test_labeled_slider.py index 888c414..495585e 100644 --- a/tests/test_sliders/test_labeled_slider.py +++ b/tests/test_sliders/test_labeled_slider.py @@ -67,9 +67,10 @@ def test_labeled_signals(cls, qtbot): @pytest.mark.parametrize( "cls", [QLabeledDoubleSlider, QLabeledRangeSlider, QLabeledSlider] ) -def test_editing_finished_signal(cls): - slider = cls() +def test_editing_finished_signal(cls, qtbot): mock = Mock() + slider = cls() + qtbot.addWidget(slider) slider.editingFinished.connect(mock) if hasattr(slider, "_label"): slider._label.editingFinished.emit()