CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-12 11:27:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixing bug where VarCreate event does not fire when adding a block with pre-existing variables from the flyout into the workspace.

Browse Source
This commit is contained in:
Karishma Chadha
2017-11-22 12:50:00 -05:00
parent 3a6d84e0c2
commit 07d6624625
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
core/flyout_base.js
View File

@@ -606,6 +606,7 @@ Blockly.Flyout.prototype.onMouseDown_ = function(e) {
Blockly.Flyout.prototype.createBlock = function(originalBlock) {
var newBlock = null;
Blockly.Events.disable();
var variablesBeforeCreation = this.workspace_.getAllVariables();
this.targetWorkspace_.setResizesEnabled(false);
try {
newBlock = this.placeNewBlock_(originalBlock);
@@ -615,9 +616,28 @@ Blockly.Flyout.prototype.createBlock = function(originalBlock) {
Blockly.Events.enable();
}
var variablesAfterCreation = this.workspace_.getAllVariables();
var variablesToFireVarCreate = [];
if (variablesBeforeCreation.length != variablesAfterCreation.length) {
for (var i = 0; i < variablesAfterCreation.length; i++) {
var variable = variablesAfterCreation[i];
// for any variable that is present in the list of variables
// after creation but is not present in the list of variables before
// creation, add the variable to the list we will traverse to
// fire the VarCreate event
if (!variablesBeforeCreation.includes(variable)) {
variablesToFireVarCreate.push(variable);
}
}
}
if (Blockly.Events.isEnabled()) {
Blockly.Events.setGroup(true);
Blockly.Events.fire(new Blockly.Events.Create(newBlock));
for(var i = 0; i < variablesToFireVarCreate.length; i++) {
var thisVariable = variablesToFireVarCreate[i];
Blockly.Events.fire(new Blockly.Events.VarCreate(thisVariable));
}
}
if (this.autoClose) {
this.hide();