Remove unused parameters from test helpers (#5032)

This commit is contained in:
Monica Kozbial
2021-07-13 13:13:06 -07:00
committed by GitHub
parent ec3da1e415
commit 0af6bc4b01
4 changed files with 8 additions and 8 deletions

View File

@@ -45,7 +45,7 @@ suite('Gesture', function() {
setup(function() {
sharedTestSetup.call(this);
defineBasicBlockWithField(this.sharedCleanup);
defineBasicBlockWithField();
var toolbox = document.getElementById('gesture-test-toolbox');
this.workspace = Blockly.inject('blocklyDiv', {toolbox: toolbox});
});

View File

@@ -18,7 +18,7 @@ suite('Key Down', function() {
* @param {Blockly.Workspace} workspace The workspace to create a new block on.
*/
function setSelectedBlock(workspace) {
defineStackBlock(this.sharedCleanup);
defineStackBlock();
Blockly.selected = workspace.newBlock('stack_block');
}

View File

@@ -456,7 +456,7 @@ function assertNthCallEventArgEquals(spy, n, instanceType, expectedProperties,
assertXmlProperties_(eventArg, xmlProperties);
}
function defineStackBlock(sharedCleanupObj) {
function defineStackBlock() {
Blockly.defineBlocksWithJsonArray([{
"type": "stack_block",
"message0": "",
@@ -465,7 +465,7 @@ function defineStackBlock(sharedCleanupObj) {
}]);
}
function defineRowBlock(sharedCleanupObj) {
function defineRowBlock() {
Blockly.defineBlocksWithJsonArray([{
"type": "row_block",
"message0": "%1",
@@ -479,7 +479,7 @@ function defineRowBlock(sharedCleanupObj) {
}]);
}
function defineStatementBlock(sharedCleanupObj) {
function defineStatementBlock() {
Blockly.defineBlocksWithJsonArray([{
"type": "statement_block",
"message0": "%1",
@@ -496,7 +496,7 @@ function defineStatementBlock(sharedCleanupObj) {
"helpUrl": ""
}]);
}
function defineBasicBlockWithField(sharedCleanupObj) {
function defineBasicBlockWithField() {
Blockly.defineBlocksWithJsonArray([{
"type": "test_field_block",
"message0": "%1",

View File

@@ -20,7 +20,7 @@ suite('Theme', function() {
Blockly.registry.typeMap_['theme'] = {};
});
function defineThemeTestBlocks(sharedCleanupObj) {
function defineThemeTestBlocks() {
Blockly.defineBlocksWithJsonArray([{
"type": "stack_block",
"message0": "",
@@ -117,7 +117,7 @@ suite('Theme', function() {
});
test('Set Theme', function() {
defineThemeTestBlocks(this.sharedCleanup);
defineThemeTestBlocks();
try {
var blockStyles = createBlockStyles();
var theme = new Blockly.Theme('themeName', blockStyles);