CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-19 23:07:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: Disallow and ignore x and y attributes for blocks in toolbox definitions. (#8785)

Browse Source 
* fix: Disallow and ignore x and y attributes for blocks in toolbox definitions.

* chore: Clarify comment in BlockFlyoutInflater.
This commit is contained in:
Aaron Dodson
2025-02-27 10:55:34 -08:00
committed by GitHub
parent 22dbd75bd4
commit 0ed6c82acc
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/block_flyout_inflater.ts
View File

@@ -101,6 +101,15 @@ export class BlockFlyoutInflater implements IFlyoutInflater {
) {
blockDefinition['disabledReasons'] = [MANUALLY_DISABLED];
}
// These fields used to be allowed and may still be present, but are
// ignored here since everything in the flyout should always be laid out
// linearly.
if ('x' in blockDefinition) {
delete blockDefinition['x'];
}
if ('y' in blockDefinition) {
delete blockDefinition['y'];
}
block = blocks.appendInternal(blockDefinition as blocks.State, workspace);
}

2
core/utils/toolbox.ts
View File

@@ -24,8 +24,6 @@ export interface BlockInfo {
disabledReasons?: string[];
enabled?: boolean;
id?: string;
x?: number;
y?: number;
collapsed?: boolean;
inline?: boolean;
data?: string;