CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 18:10:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix ios12 bug (#4517)

Browse Source 
* Changes mousedown to click event
This commit is contained in:
alschmiedt
2020-12-11 09:47:35 -08:00
committed by GitHub
parent a4e6cfe393
commit 1043257f87
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/toolbox/toolbox.js
View File

@@ -236,7 +236,7 @@ Blockly.Toolbox.prototype.createContentsContainer_ = function() {
Blockly.Toolbox.prototype.attachEvents_ = function(container,
contentsContainer) {
// Clicking on toolbox closes popups.
var clickEvent = Blockly.bindEventWithChecks_(container, 'mousedown', this,
var clickEvent = Blockly.bindEventWithChecks_(container, 'click', this,
this.onClick_, /* opt_noCaptureIdentifier */ false,
/* opt_noPreventDefault */ true);
this.boundEvents_.push(clickEvent);
@@ -257,8 +257,8 @@ Blockly.Toolbox.prototype.onClick_ = function(e) {
// Close flyout.
Blockly.hideChaff(false);
} else {
var srcElement = e.srcElement;
var itemId = srcElement.getAttribute('id');
var targetElement = e.target;
var itemId = targetElement.getAttribute('id');
if (itemId) {
var item = this.getToolboxItemById(itemId);
if (item.isSelectable()) {

4
tests/mocha/toolbox_test.js
View File

@@ -130,14 +130,14 @@ suite('Toolbox', function() {
test('Toolbox clicked -> Should close flyout', function() {
var hideChaffStub = sinon.stub(Blockly, "hideChaff");
var evt = new MouseEvent('pointerdown', {});
var evt = new MouseEvent('click', {});
this.toolbox.HtmlDiv.dispatchEvent(evt);
sinon.assert.calledOnce(hideChaffStub);
});
test('Category clicked -> Should select category', function() {
var categoryXml = document.getElementsByClassName('blocklyTreeRow')[0];
var evt = {
'srcElement': categoryXml
'target': categoryXml
};
var item = this.toolbox.contentMap_[categoryXml.getAttribute('id')];
var setSelectedSpy = sinon.spy(this.toolbox, 'setSelectedItem');