CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-10 02:17:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: isPrime block should cast str as num (#5680)

Browse Source 
Fixes #5678
This commit is contained in:
Neil Fraser
2021-11-05 11:12:25 -07:00
committed by GitHub
parent 3746688ebd
commit 1c3f4f0524
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
generators/javascript/math.js
View File

@@ -157,7 +157,7 @@ Blockly.JavaScript['math_number_property'] = function(block) {
'mathIsPrime',
['function ' + Blockly.JavaScript.FUNCTION_NAME_PLACEHOLDER_ + '(n) {',
' // https://en.wikipedia.org/wiki/Primality_test#Naive_methods',
' if (n === 2 || n === 3) {',
' if (n == 2 || n == 3) {',
' return true;',
' }',
' // False if n is NaN, negative, is 1, or not whole.',

2
tests/generators/golden/generated.js
View File

@@ -427,7 +427,7 @@ function test_constant() {
function mathIsPrime(n) {
// https://en.wikipedia.org/wiki/Primality_test#Naive_methods
if (n === 2 || n === 3) {
if (n == 2 || n == 3) {
return true;
}
// False if n is NaN, negative, is 1, or not whole.