CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 17:40:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use IVariableModel instead of VariableModel. (#8400)

Browse Source 
* refactor: Use IVariableModel methods instead of directly accessing properties.

* refactor: replace references to VariableModel with IVariableModel.
This commit is contained in:
Aaron Dodson
2024-07-19 14:58:04 -07:00
committed by GitHub
parent 02e64bebbe
commit 294ef74d1b
22 changed files with 248 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/variable_model.ts
View File

@@ -26,7 +26,7 @@ import {IVariableModel, IVariableState} from './interfaces/i_variable_model.js';
* @see {Blockly.FieldVariable}
*/
export class VariableModel implements IVariableModel<IVariableState> {
type: string;
private type: string;
private readonly id_: string;
/**
@@ -39,8 +39,8 @@ export class VariableModel implements IVariableModel<IVariableState> {
* @param opt_id The unique ID of the variable. This will default to a UUID.
*/
constructor(
public workspace: Workspace,
public name: string,
private workspace: Workspace,
private name: string,
opt_type?: string,
opt_id?: string,
) {
@@ -130,7 +130,9 @@ export class VariableModel implements IVariableModel<IVariableState> {
* @internal
*/
static compareByName(var1: VariableModel, var2: VariableModel): number {
return var1.name.localeCompare(var2.name, undefined, {sensitivity: 'base'});
return var1
.getName()
.localeCompare(var2.getName(), undefined, {sensitivity: 'base'});
}
}