CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-11 19:07:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary block dispose that was causing test leakage. (#4210)

Browse Source 
* Remove unnecessary block dispose that was causing test leakage.

* Remove unused block array.
This commit is contained in:
Monica Kozbial
2020-08-20 19:00:48 -07:00
committed by GitHub
parent a9f1d2e219
commit 30e231bb71
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/mocha/json_test.js
View File

@@ -8,17 +8,12 @@ suite('JSON Block Definitions', function() {
setup(function() {
sharedTestSetup.call(this);
this.workspace_ = new Blockly.Workspace();
this.blocks_ = [];
this.blockTypes_ = [];
this.messages_ = [];
});
teardown(function() {
sharedTestTeardown.call(this);
for (var i = 0; i < this.blocks_.length; i++) {
var block = this.blocks_[i];
block.dispose();
}
for (var i = 0, blockType; (blockType = this.blockTypes_[i]); i++) {
delete Blockly.Blocks[blockType];
}
@@ -40,7 +35,6 @@ suite('JSON Block Definitions', function() {
}]);
block = new Blockly.Block(workspace, BLOCK_TYPE);
});
this.blocks_.push(block);
chai.assert.isNotNull(block);
chai.assert.equal(BLOCK_TYPE, block.type);
@@ -164,7 +158,6 @@ suite('JSON Block Definitions', function() {
}]);
var block = new Blockly.Block(this.workspace_, BLOCK_TYPE);
this.blocks_.push(block);
chai.assert.equal(block.inputList.length, 2);
chai.assert.equal(block.inputList[0].fieldRow.length, 1);
@@ -192,7 +185,6 @@ suite('JSON Block Definitions', function() {
}]);
var block = new Blockly.Block(this.workspace_, BLOCK_TYPE);
this.blocks_.push(block);
chai.assert.equal(block.inputList.length, 1);
chai.assert.equal(block.inputList[0].fieldRow.length, 1);
var textField = block.inputList[0].fieldRow[0];
@@ -224,7 +216,6 @@ suite('JSON Block Definitions', function() {
}]);
var block = new Blockly.Block(this.workspace_, BLOCK_TYPE);
this.blocks_.push(block);
chai.assert.equal(block.inputList.length, 1);
chai.assert.equal(block.inputList[0].fieldRow.length, 1);
var dropdown = block.inputList[0].fieldRow[0];
@@ -285,7 +276,6 @@ suite('JSON Block Definitions', function() {
}]);
var block = new Blockly.Block(this.workspace_, BLOCK_TYPE);
this.blocks_.push(block);
chai.assert.equal(block.inputList.length, 1);
chai.assert.equal(block.inputList[0].fieldRow.length, 1);
var dropdown = block.inputList[0].fieldRow[0];