CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-06 08:30:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: bad JSON state leaving events disabled (#7501)

Browse Source 
* fix: broken JSON state stopping event firing

* chore: add unit test for events not breaking
This commit is contained in:
Beka Westberg
2023-09-19 05:17:51 -07:00
committed by GitHub
parent f8a134caef
commit 32c9daf885
2 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/serialization/blocks.ts
View File

@@ -399,9 +399,13 @@ export function appendInternal(
}
eventUtils.disable();
const block = appendPrivate(state, workspace, {parentConnection, isShadow});
let block;
try {
block = appendPrivate(state, workspace, {parentConnection, isShadow});
} finally {
eventUtils.enable();
}
eventUtils.enable();
if (eventUtils.isEnabled()) {
eventUtils.fire(new (eventUtils.get(eventUtils.BLOCK_CREATE))(block));
}

19
tests/mocha/jso_deserialization_test.js
View File

@@ -23,6 +23,25 @@ suite('JSO Deserialization', function () {
});
suite('Events', function () {
test('bad JSON does not leave events disabled', function () {
const state = {
'blocks': {
'blocks': [
{
'type': 'undefined_block',
},
],
},
};
chai.assert.throws(() => {
Blockly.serialization.workspaces.load(state, this.workspace);
});
chai.assert.isTrue(
Blockly.Events.isEnabled(),
'Expected events to be enabled',
);
});
suite('Finished loading', function () {
test('Just var', function () {
const state = {