Only add a hat if there's no output connection or previous connection (#3280)

* Only add a hat if there's no output connection or previous connection
This commit is contained in:
Sam El-Husseini
2019-10-17 14:08:06 -05:00
committed by GitHub
parent ce02665044
commit 36524a3b4a
2 changed files with 5 additions and 3 deletions

View File

@@ -253,9 +253,10 @@ Blockly.blockRendering.RenderInfo.prototype.createRows_ = function() {
* @package
*/
Blockly.blockRendering.RenderInfo.prototype.populateTopRow_ = function() {
var hasHat = this.block_.hat ?
this.block_.hat === 'cap' : Blockly.BlockSvg.START_HAT;
var hasPrevious = !!this.block_.previousConnection;
var hasHat = (this.block_.hat ?
this.block_.hat === 'cap' : Blockly.BlockSvg.START_HAT) &&
!this.outputConnection && !hasPrevious;
var leftSquareCorner = this.topRow.hasLeftSquareCorner(this.block_);
if (leftSquareCorner) {

View File

@@ -283,7 +283,8 @@ Blockly.utils.object.inherits(Blockly.blockRendering.TopRow,
* @return {boolean} Whether or not the top row has a left square corner.
*/
Blockly.blockRendering.TopRow.prototype.hasLeftSquareCorner = function(block) {
var hasHat = block.hat ? block.hat === 'cap' : Blockly.BlockSvg.START_HAT;
var hasHat = (block.hat ? block.hat === 'cap' : Blockly.BlockSvg.START_HAT) &&
!block.outputConnection && !block.previousConnection;
var prevBlock = block.getPreviousBlock();
return !!block.outputConnection ||