CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-08 17:40:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid spurious rename event

Browse Source
This commit is contained in:
Rachel Fenichel
2017-12-06 16:57:46 -08:00
parent 0909af76e5
commit 3cecc0f604
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/variable_map.js
View File

@@ -107,14 +107,16 @@ Blockly.VariableMap.prototype.renameVariableWithConflict_ = function(variable,
var type = variable.type;
Blockly.Events.setGroup(true);
Blockly.Events.fire(new Blockly.Events.VarRename(conflictVar, newName));
var oldCase = conflictVar.name;
conflictVar.name = newName;
// These blocks refer to the same variable but the case may have changed.
// No change events should be fired here.
var blocks = this.workspace.getAllBlocks();
if (newName != oldCase) {
// Only fire a rename event if the case changed.
Blockly.Events.fire(new Blockly.Events.VarRename(conflictVar, newName));
conflictVar.name = newName;
// These blocks refer to the same variable but the case changed.
// No change events should be fired here.
for (var i = 0; i < blocks.length; i++) {
blocks[i].updateVarName(conflictVar);
}