CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2025-12-16 14:20:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent duplication of comment icon bubbles (#8053)

Browse Source
This commit is contained in:
Richard Knoll
2024-05-02 08:38:40 -07:00
committed by GitHub
parent 19fa49101a
commit 4861c7d98a
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
core/icons/comment_icon.ts
View File

@@ -264,15 +264,18 @@ export class CommentIcon extends Icon implements IHasBubble, ISerializable {
}
async setBubbleVisible(visible: boolean): Promise<void> {
if (visible && (this.textBubble || this.textInputBubble)) return;
if (!visible && !(this.textBubble || this.textInputBubble)) return;
if (this.bubbleVisiblity === visible) return;
this.bubbleVisiblity = visible;
if (!this.sourceBlock.rendered || this.sourceBlock.isInFlyout) return;
await renderManagement.finishQueuedRenders();
if (
!this.sourceBlock.rendered ||
this.sourceBlock.isInFlyout ||
this.sourceBlock.isInsertionMarker()
)
return;
if (visible) {
if (this.sourceBlock.isEditable()) {
this.showEditableBubble();