CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-09 01:50:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rename getDeveloperVars() as getDeveloperVariables() (PR #2021)

Browse Source 
Merge pull request #2021, a rebase of #1979 (from AnmAtAnm/pr1979-rebase)
This commit is contained in:
Andrew n marshall
2018-08-28 10:30:26 -07:00
committed by GitHub
parent aae8277513 c7c9580c51
commit 512c746a53
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
core/variables.js
View File

@@ -91,6 +91,12 @@ Blockly.Variables.allUsedVariables = function() {
'issue please file a bug on GitHub.');
};
/**
* @private
* @type {Object<string,boolean>}
*/
Blockly.Variables.ALL_DEVELOPER_VARS_WARNINGS_BY_BLOCK_TYPE_ = {};
/**
* Find all developer variables used by blocks in the workspace.
* Developer variables are never shown to the user, but are declared as global
@@ -106,8 +112,21 @@ Blockly.Variables.allDeveloperVariables = function(workspace) {
var hash = {};
for (var i = 0; i < blocks.length; i++) {
var block = blocks[i];
if (block.getDeveloperVars) {
var devVars = block.getDeveloperVars();
var getDeveloperVariables = block.getDeveloperVariables;
if (!getDeveloperVariables && block.getDeveloperVars) {
// August 2018: getDeveloperVars() was deprecated and renamed
// getDeveloperVariables().
getDeveloperVariables = block.getDeveloperVars;
if (!Blockly.Variables.ALL_DEVELOPER_VARS_WARNINGS_BY_BLOCK_TYPE_[
block.type]) {
console.warn('Function getDeveloperVars() deprecated. Use ' +
'getDeveloperVariables() (block type \'' + block.type + '\')');
Blockly.Variables.ALL_DEVELOPER_VARS_WARNINGS_BY_BLOCK_TYPE_[
block.type] = true;
}
}
if (getDeveloperVariables) {
var devVars = getDeveloperVariables();
for (var j = 0; j < devVars.length; j++) {
hash[devVars[j]] = devVars[j];
}