Stop overriding @protected methods with @private (#4760)

An upcoming change to emit private properties in Google's internal version of
https://github.com/angular/clutz will otherwise break any
TypeScript depending on these types. This is because TypeScript errors
on overriding protected with private (Closure Compiler does not).
This commit is contained in:
Laura Harker
2021-04-06 13:05:41 -05:00
committed by GitHub
parent f48db6daa9
commit 5ff76ae32d
10 changed files with 22 additions and 12 deletions

View File

@@ -1380,7 +1380,8 @@ Blockly.BlockSvg.prototype.moveNumberedInputBefore = function(
* @param {string} name Language-neutral identifier which may used to find this
* input again. Should be unique to this block.
* @return {!Blockly.Input} The input object created.
* @private
* @protected
* @override
*/
Blockly.BlockSvg.prototype.appendInput_ = function(type, name) {
var input = Blockly.BlockSvg.superClass_.appendInput_.call(this, type, name);

View File

@@ -181,7 +181,8 @@ Blockly.FieldAngle.RADIUS = Blockly.FieldAngle.HALF - 1;
/**
* Configure the field based on the given map of options.
* @param {!Object} config A map of options to configure the field based on.
* @private
* @protected
* @override
*/
Blockly.FieldAngle.prototype.configure_ = function(config) {
Blockly.FieldAngle.superClass_.configure_.call(this, config);
@@ -246,7 +247,7 @@ Blockly.FieldAngle.prototype.initView = function() {
/**
* Updates the graph when the field rerenders.
* @private
* @protected
* @override
*/
Blockly.FieldAngle.prototype.render_ = function() {

View File

@@ -88,7 +88,8 @@ Blockly.FieldCheckbox.prototype.CURSOR = 'default';
/**
* Configure the field based on the given map of options.
* @param {!Object} config A map of options to configure the field based on.
* @private
* @protected
* @override
*/
Blockly.FieldCheckbox.prototype.configure_ = function(config) {
Blockly.FieldCheckbox.superClass_.configure_.call(this, config);

View File

@@ -153,7 +153,8 @@ Blockly.FieldColour.prototype.columns_ = 0;
/**
* Configure the field based on the given map of options.
* @param {!Object} config A map of options to configure the field based on.
* @private
* @protected
* @override
*/
Blockly.FieldColour.prototype.configure_ = function(config) {
Blockly.FieldColour.superClass_.configure_.call(this, config);

View File

@@ -164,7 +164,8 @@ Blockly.FieldImage.prototype.isDirty_ = false;
/**
* Configure the field based on the given map of options.
* @param {!Object} config A map of options to configure the field based on.
* @private
* @protected
* @override
*/
Blockly.FieldImage.prototype.configure_ = function(config) {
Blockly.FieldImage.superClass_.configure_.call(this, config);

View File

@@ -132,7 +132,8 @@ Blockly.FieldMultilineInput.prototype.initView = function() {
* Get the text from this field as displayed on screen. May differ from getText
* due to ellipsis, and other formatting.
* @return {string} Currently displayed text.
* @private
* @protected
* @override
*/
Blockly.FieldMultilineInput.prototype.getDisplayText_ = function() {
var textLines = this.getText();

View File

@@ -105,7 +105,8 @@ Blockly.FieldNumber.prototype.SERIALIZABLE = true;
/**
* Configure the field based on the given map of options.
* @param {!Object} config A map of options to configure the field based on.
* @private
* @protected
* @override
*/
Blockly.FieldNumber.prototype.configure_ = function(config) {
Blockly.FieldNumber.superClass_.configure_.call(this, config);

View File

@@ -127,7 +127,7 @@ Blockly.Mutator.prototype.drawIcon_ = function(group) {
* Clicking on the icon toggles if the mutator bubble is visible.
* Disable if block is uneditable.
* @param {!Event} e Mouse click event.
* @private
* @protected
* @override
*/
Blockly.Mutator.prototype.iconClick_ = function(e) {

View File

@@ -463,7 +463,8 @@ Blockly.RenderedConnection.prototype.onFailedConnect = function(
* Disconnect two blocks that are connected by this connection.
* @param {!Blockly.Block} parentBlock The superior block.
* @param {!Blockly.Block} childBlock The inferior block.
* @private
* @protected
* @override
*/
Blockly.RenderedConnection.prototype.disconnectInternal_ = function(parentBlock,
childBlock) {
@@ -484,7 +485,8 @@ Blockly.RenderedConnection.prototype.disconnectInternal_ = function(parentBlock,
/**
* Respawn the shadow block if there was one connected to the this connection.
* Render/rerender blocks as needed.
* @private
* @protected
* @override
*/
Blockly.RenderedConnection.prototype.respawnShadow_ = function() {
Blockly.RenderedConnection.superClass_.respawnShadow_.call(this);

View File

@@ -120,7 +120,8 @@ Blockly.geras.Drawer.prototype.drawBottom_ = function() {
/**
* Add steps for the left side of the block, which may include an output
* connection
* @private
* @protected
* @override
*/
Blockly.geras.Drawer.prototype.drawLeft_ = function() {
this.highlighter_.drawLeft();