CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-03-10 23:30:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixing issues with workspace dispose in event tests. (#4211)

Browse Source 
* Fixing issues with workspace dispose in event tests.
This commit is contained in:
Monica Kozbial
2020-08-31 16:35:36 -07:00
committed by GitHub
parent 43b23f6d4a
commit 61bdbc5034
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/mocha/event_test.js
View File

@@ -32,12 +32,12 @@ suite('Events', function() {
delete Blockly.Blocks['simple_test_block'];
});
function createSimpleTestBlock(workspace, opt_prototypeName) {
function createSimpleTestBlock(workspace) {
// Disable events while constructing the block: this is a test of the
// Blockly.Event constructors, not the block constructor.s
Blockly.Events.disable();
var block = new Blockly.Block(
workspace, opt_prototypeName || 'simple_test_block');
workspace, 'simple_test_block');
Blockly.Events.enable();
return block;
}
@@ -223,15 +223,17 @@ suite('Events', function() {
suite('With variable getter blocks', function() {
setup(function() {
this.genUidStub = createGenUidStubWithReturns(this.TEST_BLOCK_ID);
this.block =
createSimpleTestBlock(this.workspace, 'field_variable_test_block');
this.genUidStub = createGenUidStubWithReturns(
[this.TEST_BLOCK_ID, 'test_var_id', 'test_group_id']);
// Disabling events when creating a block with variable can cause issues
// at workspace dispose.
this.block = new Blockly.Block(
this.workspace, 'field_variable_test_block');
});
test('Change', function() {
var event = new Blockly.Events.Change(
this.block, 'field', 'VAR', 'id1', 'id2');
sinon.assert.calledOnce(this.genUidStub);
assertEventEquals(event, Blockly.Events.CHANGE, this.workspace.id,
this.TEST_BLOCK_ID,
{
@@ -247,7 +249,6 @@ suite('Events', function() {
test('Block change', function() {
var event = new Blockly.Events.BlockChange(
this.block, 'field', 'VAR', 'id1', 'id2');
sinon.assert.calledOnce(this.genUidStub);
assertEventEquals(event, Blockly.Events.CHANGE, this.workspace.id,
this.TEST_BLOCK_ID,
{