CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-11 19:07:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add warning to blockToCode (#4492)

Browse Source 
* Add warning to blockToCode

* Address PR comments
This commit is contained in:
Monica Kozbial
2020-12-07 10:38:32 -08:00
committed by GitHub
parent dd977b295b
commit 6510e49162
6 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
core/generator.js
View File

@@ -77,6 +77,15 @@ Blockly.Generator.prototype.COMMENT_WRAP = 60;
*/
Blockly.Generator.prototype.ORDER_OVERRIDES = [];
/**
* Whether the init method has been called.
* Generators that set this flag to false after creation and true in init
* will cause blockToCode to emit a warning if the generator has not been
* initialized. If this flag is untouched, it will have no effect.
* @type {?boolean}
*/
Blockly.Generator.prototype.isInitialized = null;
/**
* Generate code for all blocks in the workspace to the specified language.
* @param {Blockly.Workspace} workspace Workspace to generate code from.
@@ -167,6 +176,10 @@ Blockly.Generator.prototype.allNestedComments = function(block) {
* operator order value. Returns '' if block is null.
*/
Blockly.Generator.prototype.blockToCode = function(block, opt_thisOnly) {
if (this.isInitialized === false) {
console.warn(
'Generator init was not called before blockToCode was called.');
}
if (!block) {
return '';
}

7
generators/dart.js
View File

@@ -71,6 +71,12 @@ Blockly.Dart.ORDER_CASCADE = 15; // ..
Blockly.Dart.ORDER_ASSIGNMENT = 16; // = *= /= ~/= %= += -= <<= >>= &= ^= |=
Blockly.Dart.ORDER_NONE = 99; // (...)
/**
* Whether the init method has been called.
* @type {?boolean}
*/
Blockly.Dart.isInitialized = false;
/**
* Initialise the database of variable names.
* @param {!Blockly.Workspace} workspace Workspace to generate code from.
@@ -111,6 +117,7 @@ Blockly.Dart.init = function(workspace) {
Blockly.Dart.definitions_['variables'] =
'var ' + defvars.join(', ') + ';';
}
this.isInitialized = true;
};
/**

7
generators/javascript.js
View File

@@ -113,6 +113,12 @@ Blockly.JavaScript.ORDER_OVERRIDES = [
[Blockly.JavaScript.ORDER_LOGICAL_OR, Blockly.JavaScript.ORDER_LOGICAL_OR]
];
/**
* Whether the init method has been called.
* @type {?boolean}
*/
Blockly.JavaScript.isInitialized = false;
/**
* Initialise the database of variable names.
* @param {!Blockly.Workspace} workspace Workspace to generate code from.
@@ -153,6 +159,7 @@ Blockly.JavaScript.init = function(workspace) {
Blockly.JavaScript.definitions_['variables'] =
'var ' + defvars.join(', ') + ';';
}
this.isInitialized = true;
};
/**

7
generators/lua.js
View File

@@ -79,6 +79,12 @@ Blockly.Lua.ORDER_NONE = 99;
* option used for lists and text.
*/
/**
* Whether the init method has been called.
* @type {?boolean}
*/
Blockly.Lua.isInitialized = false;
/**
* Initialise the database of variable names.
* @param {!Blockly.Workspace} workspace Workspace to generate code from.
@@ -97,6 +103,7 @@ Blockly.Lua.init = function(workspace) {
Blockly.Lua.variableDB_.reset();
}
Blockly.Lua.variableDB_.setVariableMap(workspace.getVariableMap());
this.isInitialized = true;
};
/**

7
generators/php.js
View File

@@ -117,6 +117,12 @@ Blockly.PHP.ORDER_OVERRIDES = [
[Blockly.PHP.ORDER_LOGICAL_OR, Blockly.PHP.ORDER_LOGICAL_OR]
];
/**
* Whether the init method has been called.
* @type {?boolean}
*/
Blockly.PHP.isInitialized = false;
/**
* Initialise the database of variable names.
* @param {!Blockly.Workspace} workspace Workspace to generate code from.
@@ -154,6 +160,7 @@ Blockly.PHP.init = function(workspace) {
// Declare all of the variables.
Blockly.PHP.definitions_['variables'] = defvars.join('\n');
this.isInitialized = true;
};
/**

7
generators/python.js
View File

@@ -125,6 +125,12 @@ Blockly.Python.ORDER_OVERRIDES = [
[Blockly.Python.ORDER_LOGICAL_OR, Blockly.Python.ORDER_LOGICAL_OR]
];
/**
* Whether the init method has been called.
* @type {?boolean}
*/
Blockly.Python.isInitialized = false;
/**
* Initialise the database of variable names.
* @param {!Blockly.Workspace} workspace Workspace to generate code from.
@@ -166,6 +172,7 @@ Blockly.Python.init = function(workspace) {
}
Blockly.Python.definitions_['variables'] = defvars.join('\n');
this.isInitialized = true;
};
/**