CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-10 02:17:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Prevent dataset IDs from being renamed

Browse Source 
The JS Compiler would rename ‘id’ and ‘blockId’ to something random.  Normally that would be fine, but if it ended up with a ‘$’ in the name, then that becomes an illegal HTML property name and Blockly crashes.

A bug that’s been lurking in Blockly for years and randomly surfaced on a recent compile.
This commit is contained in:
Neil Fraser
2019-09-25 19:49:08 -07:00
committed by Neil Fraser
parent 75cf614104
commit 6ef84035ca
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/block_svg.js
View File

@@ -115,7 +115,7 @@ Blockly.BlockSvg = function(workspace, prototypeName, opt_id) {
// Expose this block's ID on its top-level SVG group.
if (this.svgGroup_.dataset) {
this.svgGroup_.dataset.id = this.id;
this.svgGroup_.dataset['id'] = this.id;
}
/**

2
core/bubble.js
View File

@@ -288,7 +288,7 @@ Blockly.Bubble.prototype.getSvgRoot = function() {
*/
Blockly.Bubble.prototype.setSvgId = function(id) {
if (this.bubbleGroup_.dataset) {
this.bubbleGroup_.dataset.blockId = id;
this.bubbleGroup_.dataset['blockId'] = id;
}
};