CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-10 02:17:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: saveConnections listener not being disposed (#7407)

Browse Source
This commit is contained in:
Beka Westberg
2023-08-17 11:39:09 -07:00
committed by GitHub
parent 0dd814dee8
commit 82f6ca5766
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
core/icons/mutator_icon.ts
View File

@@ -60,6 +60,15 @@ export class MutatorIcon extends Icon implements IHasBubble {
/** The PID tracking updating the workkspace in response to user events. */
private updateWorkspacePid: ReturnType<typeof setTimeout> | null = null;
/**
* The change listener in the main workspace that triggers the saveConnections
* method when anything in the main workspace changes.
*
* Only actually registered to listen for events while the mutator bubble is
* open.
*/
private saveConnectionsListener: (() => void) | null = null;
constructor(
private readonly flyoutBlockTypes: string[],
protected readonly sourceBlock: BlockSvg,
@@ -169,6 +178,12 @@ export class MutatorIcon extends Icon implements IHasBubble {
} else {
this.miniWorkspaceBubble?.dispose();
this.miniWorkspaceBubble = null;
if (this.saveConnectionsListener) {
this.sourceBlock.workspace.removeChangeListener(
this.saveConnectionsListener,
);
}
this.saveConnectionsListener = null;
}
eventUtils.fire(
@@ -254,12 +269,12 @@ export class MutatorIcon extends Icon implements IHasBubble {
/** Adds a listen to the source block that triggers saving connections. */
private addSaveConnectionsListener() {
if (!this.sourceBlock.saveConnections || !this.rootBlock) return;
const saveConnectionsListener = () => {
this.saveConnectionsListener = () => {
if (!this.sourceBlock.saveConnections || !this.rootBlock) return;
this.sourceBlock.saveConnections(this.rootBlock);
};
saveConnectionsListener();
this.sourceBlock.workspace.addChangeListener(saveConnectionsListener);
this.saveConnectionsListener();
this.sourceBlock.workspace.addChangeListener(this.saveConnectionsListener);
}
/**