CodingPirates/blockly
1
0
Fork 0
mirror of https://github.com/google/blockly.git synced 2026-01-10 18:37:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert bubble dragger logic change and helper name change (#4897)

Browse Source 
* Revert accidental change in bubble drag logic

* Revert name change
This commit is contained in:
Monica Kozbial
2021-06-11 11:10:39 -07:00
committed by GitHub
parent 73b06f14bb
commit 8aeb78eff3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/block_dragger.js
View File

@@ -290,7 +290,7 @@ Blockly.BlockDragger.prototype.endDrag = function(e, currentDragDeltaXY) {
} else {
this.draggingBlock_.setDragging(false);
if (delta) { // !preventMove
this.updateBlockLocationAfterMove_(delta);
this.updateBlockAfterMove_(delta);
} else {
// Blocks dragged directly from a flyout may need to be bumped into
// bounds.
@@ -313,7 +313,7 @@ Blockly.BlockDragger.prototype.endDrag = function(e, currentDragDeltaXY) {
* the block started the drag to where it ended the drag.
* @protected
*/
Blockly.BlockDragger.prototype.updateBlockLocationAfterMove_ = function(delta) {
Blockly.BlockDragger.prototype.updateBlockAfterMove_ = function(delta) {
this.draggingBlock_.moveConnections(delta.x, delta.y);
this.fireMoveEvent_();
if (this.draggedConnectionManager_.wouldConnectBlock()) {

2
core/bubble_dragger.js
View File

@@ -217,7 +217,7 @@ Blockly.BubbleDragger.prototype.endBubbleDrag = function(
if (this.dragSurface_) {
this.dragSurface_.clearAndHide(this.workspace_.getBubbleCanvas());
}
if (this.draggingBubble_) {
if (this.draggingBubble_.setDragging) {
this.draggingBubble_.setDragging(false);
}
this.fireMoveEvent_();